feat: scatter plot implementation (WIP) #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in progress, this comment defines required new types and updates the parser definition.
Also, update types needed for scatter plot and parser rule for scatter plot query statement
Also, update scatter query types to include only necessary fields
Next, need to implement Python side
Next, need to handle CombinedExpressionScatter to collect scatter results during second evaluation pass
The combine_plot_results function still needs to be updated to work with scatter plot
…plots Scatter plot code now functional. Need to implement scatter plot style for the Plotly plots.
Adding "as lines" plots ueses lines for scatter plot using the syntax (x,y) as lines=
Add tests for all scatter plot error paths and fix some scatter plot error issues
Visual test makes sure function and identical scatter line plot look the same
Slice already makes a shallow copy, the spread was unnecessary. Shouldn't change functionality
Also, update plotting tutorials for scatter plot features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, this comment defines required new types and updates the parser definition.