Default Unit Updates #217
Merged
Default Unit Updates #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses the confusion raised in #208
sec now defaults to s, ampere now defaults to A, kelvin now defaults to K, candelar now defaults to cd, and mole now defaults to mol
mgreminger
changed the title
Still need to pass custom_base_units to get_result function via evaluate_statements function
Need to implement TypeScript portion next
Still need to update math and plot cells to display user selected default units
Still need to force recalculation when default base units are changed. Also, will need to update plot cells which will required updates to the Python code to include user base units (requires update to PlotData type).
Still need to implement in the plot cell on the TypeScript side
Still needs to be implemented for Python code generation
This is necessary since the Python side defines the default result units
Added to sheet configuration dialog. Added buttons for SI, mm-kg-sec, and in-lbm-sec
…ormation category
Add dyn*cm as one of the torque unit options
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses the confusion raised in #208