feat: preserve result height when results are invalidated on edit #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done instead of deleting the results to reduce vertical jumping on updates.
Previous tests look for stale results to be detached, now they are hidden to prevent layout jumps
Prevents missed changes during debounce timeout
The only ones that remain are those that require a rendering change. All of those the were included to trigger a recalculation should be covered by an update th mathcellchanged
Removing `$cells = $cells` entirely failed since DOM updates for parsing errors were no longer being applied.
Creates a larger target for focusing using a mouse or touch input
Should improve startup time and reduce memory usage at startup
For tall cells, it is sometimes hidden after clicking the delete button
This preserves the browser's using of Control+Minus to zoom out
Parse and store statement at time of edit instead of at time of assembling statements for solver. Also, fix crash when last table row is selected and earlier row is deleted. Test added for this case as well.
Or if parameter or unit rows are changed
Previously, they were reparse on any sheet change
Since table parsing is skipped if there is a syntax error anywhere in the table, even an edit on an inactive row can impact table parsing
Especially important for sheet loading since this function will get called for every math field in a table but the result will always be the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done instead of deleting the results to reduce vertical jumping on updates.