fix: fix dimension handling for matrix indexing (WIP) #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lays groundwork for fixing issues with units and matrix indexing
No known issue where this happens but this will catch catch implementation flaws with matrix functions
…ed to be unitless Currently used for exponents, will be used for matrix indices and the arguments to range()
Tests have been added
Ensures that matrix indexing is correct for dimensional analysis pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will use same logic that is currently used to handle exponents since matrix indexes need to be unitless and their numerical value is needed to correctly perform dimensional analysis.