Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: perform dimensional analysis and numerical evaluation in same pass (WIP) #312

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
+469 −473
Open

refactor: perform dimensional analysis and numerical evaluation in same pass (WIP) #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
b108310
refactor: simplify logic for preventing unit canceling
mgreminger Jan 3, 2025
c9f5f73
refactor: move all multiplication dimensional analysis logic to place…
mgreminger Jan 3, 2025
4128bdf
refactor: remove unused variable
mgreminger Jan 3, 2025
0aa0e43
refactor: eliminate need for unitless expression pass
mgreminger Jan 5, 2025
439bee2
fix: fix user function regressions
mgreminger Jan 6, 2025
e60bb21
fix: fix matrix indexing regression
mgreminger Jan 6, 2025
014090a
fix: fix code generation regression
mgreminger Jan 6, 2025
f184195
fix: fix intermediate result rendering regression
mgreminger Jan 6, 2025
8c61541
refactor: remove unnecessary lines
mgreminger Jan 7, 2025
87f8bf0
fix: fix plot label regression
mgreminger Jan 7, 2025
569a0a0
refactor: reduce complexity for dims need values logic
mgreminger Jan 7, 2025
f6ca302
tests: increase timeout for symbolic expression error test
mgreminger Jan 7, 2025
2f053c2
refactor: remove unused unitless sub query code from python code
mgreminger Jan 7, 2025
9d69544
refactor: remove unused unitless subquery code from javascript code
mgreminger Jan 7, 2025
0e447db
fix: apply evalf to exponents
mgreminger Jan 7, 2025
771036f
fix: only convert exponent to float for numeric base and exp
mgreminger Jan 7, 2025
0255ce2
fix: only switch to floating point exponents for very large rationals
mgreminger Jan 8, 2025
14ecb9c
feat: add result to DimValues dict
mgreminger Jan 8, 2025
3643dc2
fix: fix typescript compiler error
mgreminger Jan 8, 2025
0ba5eba
tests: add test for nested function calls with exponents and units
mgreminger Jan 8, 2025
c799317
fix: fix zero cancelling bug in dimensional analysis
mgreminger Jan 9, 2025
3caee93
fix: fix function with zero with units arg regression
mgreminger Jan 9, 2025
2bd9f13
fix: fix numerical solve with zero units starting guess regression
mgreminger Jan 9, 2025
d060821
fix: fix error recognizing small differences in dimension exponents a…
mgreminger Jan 10, 2025
1be9d28
Revert "fix: fix numerical solve with zero units starting guess regre…
mgreminger Jan 10, 2025
0377899
fix: preventing rounding off of exponents for dimensional analysis
mgreminger Jan 10, 2025
1d0dbbd
fix: fix numerical solve with zero units starting guess regression
mgreminger Jan 9, 2025
6423227
Revert "fix: fix error recognizing small differences in dimension exp…
mgreminger Jan 10, 2025
1313575
fix: retry at fixing recognizing small differences in dimension expon…
mgreminger Jan 11, 2025
1e23b20
fix: apply same exponent comparison logic used for adding to ensure_d…
mgreminger Jan 11, 2025
bec2e6e
fix: fix dimensional analysis regression
mgreminger Jan 11, 2025
c9fef7f
Revert "fix: apply same exponent comparison logic used for adding to …
mgreminger Jan 11, 2025
8a8814e
refactor: simplify exponent check for dimensional analysis add method
mgreminger Jan 11, 2025
67f7ba4
fix: use the adding dims logic for functions that accept multiple inp…
mgreminger Jan 12, 2025
77dcdbc
fix: regression recognition of very small unit exponent as unitless
mgreminger Jan 12, 2025
ffeaec1
refactor: only perform unit exponent rounding when necessary for comp…
mgreminger Jan 12, 2025
b9e2d84
refactor: simplify matrix inverse dimensions code
mgreminger Jan 12, 2025
cb816a3
feat: add custom error messages for all dimension errors
mgreminger Jan 12, 2025
b4a92d4
tests: update exponent round of test to match new dimension error mes…
mgreminger Jan 12, 2025
163a943
fix: fix nested function regression
mgreminger Jan 17, 2025
303f07b
refactor: simplify function wrapper detection logic
mgreminger Jan 17, 2025
100844e
Revert "refactor: simplify function wrapper detection logic"
mgreminger Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playwright.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const config = {
forbidOnly: !!process.env.CI,

retries: process.env.CI ? 2 : 0,
workers: process.env.CI ? 4 : 8,
workers: process.env.CI ? 4 : 4,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: process.env.CI ? 'github' : 'list',
reportSlowTests: null,
Expand Down
Loading
Loading