Enhance support for the davmail.outlookUrl property setting (see issue #284) #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mguessan : The discussion in issue #284 recently revealed some problems with the
davmail.outlookUrl
property setting. This PR does the following:getOutlookUrl()
method to theSettings
class.Settings.getO365Url()
when thedavmail.outlookUrl
property is set. I'm inferring what the return value should be based on the other cases (when thedavmail.tld
property is set and when neither thedavmail.outlookUrl
nor thedavmail.tld
properties are set).Settings.OUTLOOK_URL
in several places where it should have been referencing thedavmail.outlookUrl
property instead. These places in the code have been changed to use the newSettings.getOutlookUrl()
.