fix(locksmith): execute to yield without arguments (#710)

Closes #683

lib/sidekiq_unique_jobs/locksmith.rb

@@ -188,7 +188,7 @@ def ==(other)
     # @yieldparam [string] job_id the sidekiq JID
     # @yieldreturn [void] whatever the calling block returns
     def lock!(conn, primed_method, wait = nil)
-      return yield job_id if locked?(conn)
+      return yield if locked?(conn)
 
       enqueue(conn) do |queued_jid|
         reflect(:debug, :queued, item, queued_jid)
@@ -199,7 +199,7 @@ def lock!(conn, primed_method, wait = nil)
 
           if locked_jid
             reflect(:debug, :locked, item, locked_jid)
-            return yield job_id
+            return yield
           end
         end
       end

spec/sidekiq_unique_jobs/lock/until_and_while_executing_spec.rb

@@ -85,6 +85,14 @@
       end
     end
 
+    it "yields without arguments" do
+      process_one.lock
+      process_one.execute {}
+      blk = -> {}
+
+      expect { process_one.execute(&blk) }.not_to raise_error
+    end
+
     context "when worker raises error in runtime lock" do
       before do
         allow(runtime_one.locksmith).to receive(:execute).and_raise(RuntimeError, "Hell")

spec/sidekiq_unique_jobs/lock/while_executing_spec.rb

@@ -66,6 +66,14 @@
       expect(callback_two).not_to have_received(:call)
     end
 
+    it "yields without arguments" do
+      process_one.lock
+      process_one.execute {}
+      blk = -> {}
+
+      expect { process_one.execute(&blk) }.not_to raise_error
+    end
+
     context "when no callback is defined" do
       let(:job_class) { WhileExecutingRescheduleJob }
       let(:callback_one) { -> { true } }

spec/support/shared_examples/a_lockable_lock.rb

@@ -83,5 +83,13 @@
 
       expect(process_two).to have_received(:reflect).with(:execution_failed, item_two)
     end
+
+    it "yields without arguments" do
+      process_one.lock
+      process_one.execute {}
+      blk = -> {}
+
+      expect { process_one.execute(&blk) }.not_to raise_error
+    end
   end
 end