Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option quoteDataWithSpaces (default - true) to unparse config. #836

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alexander-gush
Copy link

If quoteDataWithSpaces set to false, unparse result doesn't quote data with spaces in the start or in the end.

…If quoteDataWithSpaces set to false, unparse result doesn't quote data with spaces in the start or in the end.
@pokoli
Copy link
Collaborator

pokoli commented Oct 8, 2020

Hi @alexander-gush,

Thanks for your pull request. Could you please explain why this feature is usefull?
In order to accept a PR we require to have a minimal test on our test suite that ensures that your behaviour works as expected. Could you please add one?

@alexander-gush
Copy link
Author

Thank you!
Some times it may be unexpectedly that quotes appears in output but there are not in input. So I think we should give possibility to control it.
I added test.

@pokoli
Copy link
Collaborator

pokoli commented Oct 9, 2020

We are still missing the doc update (which is in the docs folder of the repository) to include the new option

@alexander-gush
Copy link
Author

We are still missing the doc update (which is in the docs folder of the repository) to include the new option

I added this option to the documentation.

@pokoli
Copy link
Collaborator

pokoli commented Mar 14, 2022

Hi @alexander-gush,

There are some conflicts with the master branch. Could you plesae rebase your work on top on it and fix them?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants