-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L4 module for Postgres: matchers #188
base: master
Are you sure you want to change the base?
L4 module for Postgres: matchers #188
Conversation
3fa7048
to
beb34b7
Compare
/cc @coolaj86 in case you'd be interested in this |
Including allowing public unauthenticated databases when no params are passed for use with readonly applications
21e7c5d
to
ac96a41
Compare
Thanks for updating this. Will probably give it another review soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks quite involved! I'm glad you are doing this 😄
I probably won't be testing it myself, so, I imagine you've tested that this works?
One other question I had is: is it possible to have just 1 matcher? I vaguely understand why Postgres SSL is different from regular SSL (but can we call it TLS?). I just wonder if we could simplify the config a bit, or maybe you can help me understand why they should be different matchers entirely... thanks!
This PR adds additional matchers for the Postgres module:
user
anddatabase
parameters when SSL is disabledapplication_name
parameter when SSL is disabledMore tests and docs are in progress, but given the discussion in #187 I'd like to share the non-SSL matchers, and discuss further enhancements to the PostgresSSL Matcher