Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L4 module "remote_ip_list" to support fail2ban #266
base: master
Are you sure you want to change the base?
L4 module "remote_ip_list" to support fail2ban #266
Changes from all commits
8bcd4c9
a47a95b
25518d2
0e0975c
e04de1e
c9ae34c
fc950b5
763fe43
afe37b1
1195830
a60cb31
c9e5659
9ac7180
160bb30
17f7307
a7d57e7
3195b17
763e43e
7f7272e
88fc0c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to double check, this won't leak goroutines on every reload because Caddy closes/shuts the
caddy.Context
on config reload and/or shutdown, right?This is the only concern I have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good eye. It does seem to check the context in its loop, and return after an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @mholt said, the main loop within the goroutine currently returns as soon as
ctx.Done()
is true or an error occurs.Is there anything else that should be checked to prevent a goroutine leak? Is
ctx.Done()
always true when the configuration is reloaded?