fix(web): fix create file tree error when folder named constructor. #637
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlelee
force-pushed
the
fix/create-file-tree-error-with-constructor
branch
from
27f4330 to
ca732b5
Compare
pavlelee
force-pushed
the
fix/create-file-tree-error-with-constructor
branch
from
ca732b5 to
9f81963
Compare
|
probably should use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number / Link: No
Summary of the issue:
If a directory in a project is called
constructor, Commit Detail View always show loading.Description outlining how this pull request resolves the issue:
normal directory:
wrong directory:
because constructor and JS constructor have the same name:
After modification:
