Introduce add family of commands for company IAM
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidebianchi
requested changes
Jan 3, 2024
docs/30_commands.md
Outdated
| @@ -210,15 +223,17 @@ Available flags for the command: | |||
| - `--insecure-skip-tls-verify`, to disallow the check the validity of the certificate of the remote endpoint | |||
| - `--context`, to specify a different context from the currently selected one | |||
| - `--company-id`, to set the ID of the desired Company | |||
| - `--output`, optional flag to save the service account json description in a file at the provided path | |||
There was a problem hiding this comment.
Description? Are saved the credentials?
There was a problem hiding this comment.
I've changed the docs to better reflect what we are saving
| } | ||
|
|
||
| options.CreateNewGroupFlags(cmd.Flags()) | ||
| err := cmd.RegisterFlagCompletionFunc("role", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { |
There was a problem hiding this comment.
Those roles should be dynamic? There is a role api, which could be used to dynamically configure this completion. What do you think?
In the future, probably the roles will change
There was a problem hiding this comment.
I will postpone the feature until a proper caching mechanism is in place for the various calls, because making an http call for every autocomplete try is not the best experience...
| } | ||
|
|
||
| func createNewGroup(ctx context.Context, client *client.APIClient, companyID, groupName string, role resources.ServiceAccountRole) error { | ||
| if !resources.IsValidServiceAccountRole(role) { |
| } | ||
|
|
||
| options.AddNewUserFlags(cmd.Flags()) | ||
| err := cmd.RegisterFlagCompletionFunc("role", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { |
There was a problem hiding this comment.
Also here, static completion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR is for?
This PR will introduce the new
addfamily of command forcompany iam.Those command are for: