-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add public flag to marketplace list #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not thoroughly convinced on the mechanics of the flag.
If I'm listing marketplace items for a company I think that I'm expecting to see all marketplace items for that company, publics and privates. Can it be that the flag will work in reverse? Like by default the value is true and the user must set it to false to see only private elements. Or mutate it to --hide-public. Can it be done via our API as they exists now?
Regarding this: At the moment the EDIT: We have defined the following behavior for our command line options:
|
28339f0
to
2f9a673
Compare
Co-authored-by: Luca Maltagliati <[email protected]>
Co-authored-by: Luca Maltagliati <[email protected]>
5a95be0
to
45a40bf
Compare
What this PR is for?
This PR adds the
--public
flag tomarketplace list
command in order to allow users to retrieve public marketplace items.