Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add public flag to marketplace list #148

Merged
merged 13 commits into from
Feb 1, 2024
Merged

Conversation

pmarchini
Copy link
Contributor

What this PR is for?

This PR adds the --public flag to marketplace list command in order to allow users to retrieve public marketplace items.

@pmarchini pmarchini requested a review from a team as a code owner January 29, 2024 18:04
@pmarchini pmarchini changed the title feat: add feat: add public flag to marketplace list Jan 29, 2024
@pmarchini pmarchini requested review from JGiola and malta895 January 29, 2024 19:00
Copy link
Member

@JGiola JGiola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not thoroughly convinced on the mechanics of the flag.

If I'm listing marketplace items for a company I think that I'm expecting to see all marketplace items for that company, publics and privates. Can it be that the flag will work in reverse? Like by default the value is true and the user must set it to false to see only private elements. Or mutate it to --hide-public. Can it be done via our API as they exists now?

@pmarchini
Copy link
Contributor Author

pmarchini commented Jan 30, 2024

I'm not thoroughly convinced on the mechanics of the flag.

If I'm listing marketplace items for a company I think that I'm expecting to see all marketplace items for that company, publics and privates. Can it be that the flag will work in reverse? Like by default the value is true and the user must set it to false to see only private elements. Or mutate it to --hide-public. Can it be done via our API as they exists now?

Regarding this:

At the moment the marketplace list command shows only private marketplace items related to a specific company (--company-id), what we want to add it's a flag that allows the user to retrieve elements from public marketplace.
We're going to change the behavior in order to show only public elements while ´--public´ flag is being set. *

EDIT:

We have defined the following behavior for our command line options:

  • --company-id: This flag is mandatory and retains its current behavior.
  • --public: When this option is used, the command output will additionally include publicly available marketplace items.

@pmarchini pmarchini force-pushed the feat/MKEA-169-public-items branch from 28339f0 to 2f9a673 Compare January 30, 2024 17:02
@pmarchini pmarchini force-pushed the feat/MKEA-169-public-items branch from 5a95be0 to 45a40bf Compare February 1, 2024 09:42
@pmarchini pmarchini merged commit 815d3b4 into main Feb 1, 2024
9 checks passed
@JGiola JGiola deleted the feat/MKEA-169-public-items branch February 1, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants