Fixes by Goose Action #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an auto-generated PR with fixes by Goose.
Task: Update SendPage to remove "Verifying DAP..." loading message
similar to what was achieved in TBD54566975#281, we want to consolidate any consecutive loading spinners into one loading page
currently, you can go to SendPage via the send tab in the bottom navigation bar. from here, typing in a dap (e.g. @moegrammer/didpay.me) and hitting the next button triggers a "Verifying DAP..." loading message followed by a "Fetching offerings..." loading message which means you have entered the payment flow starting at PaymentAmountPage
the goal of this issue is to remove the "Verifying DAP..." loading message in SendPage and instead put a small loading spinner to the right of the DAP input form when resolving the DAP
old flow: input DAP -> hit next -> see "Verifying DAP..." -> see "Fetching offerings..." -> enter PaymentAmountPage
new flow: input DAP -> hit next -> see small loading spinner next to DAP input form -> see "Fetching offerings..." -> enter PaymentAmountPage
Link to issue