Some bonded interface fixes #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HWADDR is used to match interfaces, e.g. when selecting bond members
jdub
changed the title
markgoddard
requested changes
Feb 2, 2021
There was a problem hiding this comment.
Well, TIL about MACADDR vs HWADDR. I see the logic in using MACADDR for a bond, since there is no real device to select by HWADDR. However it is a bit inconsistent now. Would it make more sense to support both macaddr and hwaddr for RH systems? is there some equivalent we can use for Ubuntu?
| @@ -15,6 +15,9 @@ netmask {{ item.netmask }} | |||
| {% if item.gateway is defined %} | |||
| gateway {{ item.gateway }} | |||
| {% endif %} | |||
| {% if item.dnsnameservers is defined %} | |||
| dns-nameservers {{ item.dnsnameservers }} | |||
| {% endif %} | |||
There was a problem hiding this comment.
Could you add the same for bridge_Debian.j2?
| @@ -25,6 +28,9 @@ hwaddress {{ item.hwaddr }} | |||
| {% if item.pre_up is defined %} | |||
| pre-up {{ item.pre_up }} | |||
| {% endif %} | |||
| {% if item.dnssearch is defined %} | |||
| dns-search {{ item.dnssearch }} | |||
| {% endif %} | |||
| {% endif %} | ||
| {% if item.dnssearch is defined %} | ||
| DOMAIN={{ item.dnssearch }} | ||
| {% endif %} |
There was a problem hiding this comment.
Could you add the same for templates/bridge_RedHat.j2?
|
It wouldn't make sense to support HWADDR for bonds and bridges, but it probably makes sense to support both for ethernet interfaces. I'll send some changes. 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onbootoptional for bonded interfaces, as it is for the others.MACADDRon Red Hat systems to set the address. [1][1] Note that I have only changed this in the bond template, because it's necessary for my use case. Changing it in the other templates would cause surprising compatibility problems if anyone is already using
hwaddrto choose the interface by MAC address.