Get name from object #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erence to other object.
michaelrsweet
requested changes
Sep 25, 2024
pdfio.h
Outdated
| @@ -220,6 +220,8 @@ extern pdfio_obj_t *pdfioObjCopy(pdfio_file_t *pdf, pdfio_obj_t *srcobj) _PDFIO_ | |||
| extern pdfio_stream_t *pdfioObjCreateStream(pdfio_obj_t *obj, pdfio_filter_t compression) _PDFIO_PUBLIC; | |||
| extern pdfio_array_t *pdfioObjGetArray(pdfio_obj_t *obj) _PDFIO_PUBLIC; | |||
| extern pdfio_dict_t *pdfioObjGetDict(pdfio_obj_t *obj) _PDFIO_PUBLIC; | |||
| extern const char *pdfioObjGetName(pdfio_obj_t *obj) _PDFIO_PUBLIC; | |||
There was a problem hiding this comment.
Tab between "const char" and "*pdfioObjGetName". Also, please move this down between ...GetLength and ...GetNumber so it is sorted alphabetically.
vlasovsoft1979
changed the title
|
@michaelrsweet |
michaelrsweet
requested changes
Sep 27, 2024
pdfio-object.c
Outdated
| @@ -268,6 +268,26 @@ pdfioObjGetDict(pdfio_obj_t *obj) // I - Object | |||
| } | |||
|
|
|||
|
|
|||
| // | |||
There was a problem hiding this comment.
Minor nit, please move this later in the file before pdfioObjGetNumber.
michaelrsweet
approved these changes
Sep 27, 2024
|
OK, holding for the next feature release (have a bug fix release to do first...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, store Image ColorSpace in the separate object: