Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unused Dialyzer ignored warnings #182

Merged

Conversation

antedeguemon
Copy link
Contributor

From OTP 26, the unknown function warnings for Jason.Encoder.(.*).__impl__ have stopped being raised by Dialyzer. It makes the dialyzer.ignore unnecessary- especially because CI only runs Dialyzer with Elixir 1.15 and OTP 26.

This pull request simply removes the dialyzer.ignore file.

From OTP 26, the Dialyzer warnings for Jason.Encoder's __impl__
unknown functions are not being raised anymore.

This makes the ignored warnings unnecessary, especially because CI
only runs Dialyzer with Elixir 1.15 and OTP 26.
@michalmuskala michalmuskala merged commit 4479adb into michalmuskala:master Feb 7, 2024
14 checks passed
@michalmuskala
Copy link
Owner

Thank you! ❤️

@antedeguemon antedeguemon deleted the vm-removes-dialyzer-ignores branch February 7, 2024 18:42
michalmuskala pushed a commit that referenced this pull request Jun 29, 2024
From OTP 26, the Dialyzer warnings for Jason.Encoder's __impl__
unknown functions are not being raised anymore.

This makes the ignored warnings unnecessary, especially because CI
only runs Dialyzer with Elixir 1.15 and OTP 26.

Co-authored-by: antedeguemon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants