Add support for making tags focusable for improved assistive technologies support #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from original
link targets should be focusable for best assistive technologies support by adding tabindex="-1" (which also keeps them out of the tab indexing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This article, local link targets must be focusable to prevent accessibility issues, suggests that focus is lost when local link anchors are not focusable, such as headings with ids. This pull request adds support for, by default, making headings with id attributes focusable via a
tabindex="-1"attribute.The implementation uses a class variable to allow overriding which tags are so enabled in a child class.
While this will change existing rendering, it will not break anything--headings with ids will continue to work as before, just with the added attribute.