-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's improve everything: less spaghetti code, scan algorithm and CI improvement, lighter binary #55
Open
pandatix
wants to merge
36
commits into
michelin:master
Choose a base branch
from
pandatix:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endencies at each build, set properly env variables and use of linux filesystem
…actor project layout to match conventions + improve code
pandatix
changed the title
Open-Source Contribution, here we go !
Let's improve everything : open-Source Contribution, here we go !
Jun 26, 2021
pandatix
changed the title
Let's improve everything : open-Source Contribution, here we go !
Overall improvement: less spaghetti code, scan algorithm and CI improvements, for a lighter binary.
Feb 11, 2022
pandatix
changed the title
Overall improvement: less spaghetti code, scan algorithm and CI improvements, for a lighter binary.
Let's improve everything: less spaghetti code, scan algorithm and CI improvement, lighter binary
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, St******* told me about this repo. I saw Go. I was not able not to contribute. 😄
So here is my PR (he challenged me to do it the 6th of april sooooo). I let you check what is new (pretty much everything) in the code, but here is a summary:
internal
at root)darwin/386
build because is not compatible with Go 1.16)README.md
for open-source contributionsIt also decreases the binary sizes with an average of -14,59%, according to the following.
darwin/386
darwin/amd64
freebsd/386
freebsd/amd64
freebsd/arm
linux/386
linux/amd64
linux/arm
linux/mips
linux/mips64
linux/mips64le
linux/mipsle
linux/s390x
netbsd/386
netbsd/amd64
netbsd/arm
openbsd/386
openbsd/amd64
windows/386
windows/amd64
THE CLI IS NOT BACKWARD COMPATIBLE.