fix(_mnn): remove false claims from help text

[michen00]

Run as _mnn, --help described a command that doesn't work:

$ _mnn --help
...
Copies em dash (Unicode U+2014) to the system clipboard.
...
Examples:
  _mnn           # Copy em dash (—) to clipboard
$ _mnn
Error: This script must be invoked as 'en_' or 'em_'

Each inline conditional in usage() tested only for en_, so every name other than en_, including a symlink under any other name, fell through to the em-dash text.

usage() now picks its text by name:

• en_ and em_ each describe their own dash and point to the other command. The note about invoking the script as en_ or em_ is gone from their help, since it told the reader to do what they had already done.
• Every other name gets a description of the shared implementation that lists both commands and their dashes, with no Examples: section, because no example would work.

$ en_ --help
Usage: en_ [OPTIONS]

Copies an en dash (–, U+2013) to the system clipboard. Use em_ for an em dash.

Options:
  -h, --help    Show this help message and exit.

Examples:
  en_
$ _mnn --help
Usage: _mnn [OPTIONS]

Shared implementation of en_ and em_; run it through one of those names.
The name decides which dash is copied to the system clipboard:

  en_   en dash (–, U+2013)
  em_   em dash (—, U+2014)

Options:
  -h, --help    Show this help message and exit.

Tests

Two _mnn help tests asserted the wording of the misdirected note; those assertions are removed. Six tests are added, and all six failed before the fix. The central one checks that every line of help that shows a dash (glyph or code point) also names the command that copies it, so the help can't say that the invoked name copies one. Against the old code, it flagged exactly the two false lines above.

Verification

• make test: 332 of 332 pass (Linux and Windows clipboard tests skip on macOS).
• tests/_mnn.bats under /bin/bash 3.2.57: 43 of 43 pass.
• make run-pre-commit: clean.

🤖 Generated with Claude Code

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[qodo-code-review]

PR Summary by Qodo

Correct _mnn help by invocation name

🐞 Bug fix 🧪 Tests 🕐 10-20 Minutes

AI Description

• Makes help truthful for direct, supported, and unrecognized invocation names.
• Direct help documents both supported commands without unusable examples.
• Adds regression coverage for command-to-dash attribution and sibling guidance.

Diagram

graph TD
  A["Help request"] --> B["usage()"] --> C{"Script name"} -->|en_| D["en_ help"]
  C -->|em_| E["em_ help"]
  C -->|other| F["Shared help"]

Loading

High-Level Assessment

The explicit case dispatch is appropriate because it mirrors the script's existing name-based behavior and keeps unsupported-name help distinct from executable examples. A generalized lookup table would add indirection without reducing meaningful complexity for only two supported aliases.

Files changed (2) +84 / -7

Bug fix (1) +29 / -5

_mnnGenerate accurate help for each invocation name +29/-5

Generate accurate help for each invocation name

• Refactors 'usage()' to select command-specific text for 'en_' and 'em_', including guidance to the sibling command. Direct and unrecognized names now describe the shared implementation, list both valid commands, and omit unusable examples.

_mnn

Tests (1) +55 / -2

_mnn.batsCover help attribution across supported and unsupported names +55/-2

Cover help attribution across supported and unsupported names

• Adds assertions for sibling-command guidance, removal of redundant invocation notes, and accurate command-to-dash attribution. Extends direct and symlinked-name coverage while removing assertions tied to the misleading text.

tests/_mnn.bats

[Copilot]

Copilot review overview

🟢 Approval recommended

The functional changes align with the PR description and the added tests cover the corrected help-text behavior, with only a minor test-helper readability nit noted.

Review effort: Lite
Findings: 1

Open (1)

• Preserve newlines when combining stray dash scan output · New

What changed in this PR

This PR fixes _mnn --help output so it no longer falsely claims that invoking the shared implementation under an arbitrary name will copy a specific dash; help text is now selected based on SCRIPT_NAME and provides accurate, name-appropriate guidance.

Changes:

• Refactors _mnn usage() to use a case on SCRIPT_NAME, emitting distinct help for en_, em_, and a “shared implementation” help for all other names.
• Removes the misleading “must be invoked as…” note from en_/em_ help while keeping direct-invocation error behavior intact.
• Updates and expands tests/_mnn.bats to validate correct help attribution and prevent future regressions.

File	Description
_mnn	Reworks usage() to generate accurate help text based on the invoked name (en_, em_, or other).
tests/​_mnn.bats	Adds targeted help-text assertions and removes assertions that enforced the previously-misleading note.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟢 Approval recommended

The help-text selection logic is corrected cleanly and the added/updated tests directly cover the previously incorrect behavior without introducing observable regressions.

Review effort: Lite
Findings: None

Resolved since last review (1)

• Preserve newlines when combining stray dash scan output