-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding bump.sh's train travel api #25
Conversation
Thanks, @philsturgeon, for this very excellent contribution. |
559b102
to
fd71dd0
Compare
@yada done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not the correct URL to final artifact that sticks to Microcks conventions. Could you please check this?
Signed-off-by: Phil Sturgeon <[email protected]>
734e92f
to
1f9ddd1
Compare
@lbroudoux now that bump-sh-examples/train-travel-api#21 is merged pointing to a good Microcks-compatible OpenAPI, and I've fixed the DCO, can you review this again? |
Yep sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
You are now a Microcks community contributor! 💖 Thanks and congrats 🚀 on merging your first pull request! We are delighted and very proud of you! 👏 📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact. If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌" Kudos and please keep going, we need you 🙌 🌟 ~~~~~~~~~ 🌟 📢 If you like Microcks, please ⭐ star ⭐ our repo to support it! 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact. |
Hey @philsturgeon! The Train API is now available on https://hub.microcks.io! You can check it out directly here: https://hub.microcks.io/package/bump.sh The Mocks have also been loaded on the https://try.microcks.io instance. You can directly check them there or try a simple call: curl -X GET 'https://try.microcks.io/rest/Train+Travel+API/1.0.0/bookings' -H 'Accept: application/json' Cheers! |
Description
Adding @bump-sh's Train Travel API as a demo API that folks can use.