parse hproduct description as p-description not e-description #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per http://microformats.org/wiki/h-product#Backward_Compatibility description in backcompat mode should be parsed as p- not e- this completes the change made in 13f9761 for the simpleproperties test
|
@willnorris @dissolve There might be some other updates to this test based on #71. Can you check and let me know? |
|
The root class in #71 issue is indeed a bit confusing. Picking up discussion there; based on decision, I'll update this PR. |
|
from discussion on #71, doesn't sound like there is anything else to change here? Only action item was a potential update to the spec to make the backcompat parsing a little clearer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per http://microformats.org/wiki/h-product#Backward_Compatibility
description in backcompat mode should be parsed as p- not e-
this completes the change made in 13f9761 for the simpleproperties test