Fixed the issue that caused quick login to crash #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does it fix other causes as well, i.e. #2424, or only exceptions thrown in some of the cases? |
mar-v-in
requested changes
Aug 4, 2024
There was a problem hiding this comment.
This only fixes the crash in the case where the error happens:
- with the first account
- at first attempt to connect
It will still crash if a connection issue happens later. The better way to fix this is to catch the exceptions when they happen in AssistedSignInFragment instead of doing some useless additional network request early to try to detect issues.
|
Processed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue that caused quick login to crash due to UNREGISTERED_ON_API_CONSOLE.
e.g. DeutschlandCard (de.deutschlandcard.app)