Skip to content

Conversation

@iamsb97
Copy link
Contributor

@iamsb97 iamsb97 commented Dec 3, 2025

Closes #12190.

Change summary:

  1. Reset nonGenerated and rawCatalog along with catalog to keep all three structures in sync.
  2. Skip cache writes while a refresh is in progress, using a volatile refreshing flag. This prevents stale values from being written into the cache after refresh starts.

@sdelamo sdelamo requested a review from dstepanov December 4, 2025 06:26
@sdelamo sdelamo added this to 5.0.0-M1 Dec 4, 2025
@github-project-automation github-project-automation bot moved this to Backlog in 5.0.0-M1 Dec 4, 2025
@dstepanov
Copy link
Contributor

Considering you are reseting different catalogues can you validate that the values are cleared

@iamsb97
Copy link
Contributor Author

iamsb97 commented Dec 4, 2025

I have added the requested test. I also verified that, without the changes to reset(), the assertion at line 150 in the Groovy test fails, since rawCatalog was not being cleared earlier. I couldn't find any usage of the nonGenerated catalog in any code path, so I’m not sure it can be verified through a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

Property cache issue when environment is refreshed

2 participants