-
Notifications
You must be signed in to change notification settings - Fork 30
Introducing OKE #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
n0tl3ss
wants to merge
133
commits into
6.1.x
Choose a base branch
from
feature/workflow1
base: 6.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Introducing OKE #534
Changes from 14 commits
Commits
Show all changes
133 commits
Select commit
Hold shift + click to select a range
71fdbd8
experiment
n0tl3ss 8f12e76
Merge branch 'master' into feature/workflow1
n0tl3ss 1003b2c
experiment
n0tl3ss e92dd4f
experiment
n0tl3ss a60ede8
experiment
n0tl3ss 81a34a0
experiment
n0tl3ss 1c06da7
experiment
n0tl3ss 0df5612
experiment
n0tl3ss 4498df8
experiment
n0tl3ss 097308c
experiment
n0tl3ss 2a3320a
experiment
n0tl3ss 7a5f32a
experiment
n0tl3ss 0eb7769
experiment
n0tl3ss 0f359c8
experiment
n0tl3ss 3fdf25b
small fixes
n0tl3ss c35909e
small fixes
n0tl3ss 66663c3
empty to trigger build
n0tl3ss c311960
empty to trigger build
n0tl3ss 1faa493
empty to trigger build
n0tl3ss 3eea457
empty to trigger build
n0tl3ss 167de58
empty to trigger build
n0tl3ss 54b1229
empty to trigger build
n0tl3ss d77e9cc
add text to CONTRIBUTING.md
n0tl3ss 09529db
empty to trigger build
n0tl3ss 4f89e74
switch discovery-client test to debug level from info
n0tl3ss bee3fd9
empty to trigger build
n0tl3ss b788688
experiment
n0tl3ss 6c47904
experiment
n0tl3ss 47f3d04
empty to trigger build
n0tl3ss 2b28d63
empty to trigger build
n0tl3ss 2d143c1
experiment
n0tl3ss 7fd7abd
experiment
n0tl3ss 6285eb4
empty to trigger build
n0tl3ss f13f4c0
experiment
n0tl3ss 41386ea
experiment
n0tl3ss 70ddf1f
experiment
n0tl3ss a3ebb82
experiment
n0tl3ss f7e6488
experiment
n0tl3ss 50dadec
experiment
n0tl3ss ee41220
experiment
n0tl3ss a58b67f
experiment
n0tl3ss 6776236
empty to trigger build
n0tl3ss 30ea16c
empty to trigger build
n0tl3ss 937e45e
empty to trigger build
n0tl3ss 132be39
experiment
n0tl3ss 7a1f1ce
experiment
n0tl3ss 1c72c6d
experiment
n0tl3ss a4c4b4c
experiment
n0tl3ss 14cea8b
experiment
n0tl3ss 9fa04be
empty to trigger build
n0tl3ss d1a8525
empty to trigger build
n0tl3ss f2d75f2
empty to trigger build
n0tl3ss 2af1d1f
empty to trigger build
n0tl3ss 2b85279
experiment
n0tl3ss 7e75a83
experiment
n0tl3ss 6a17b44
experiment
n0tl3ss 012ea24
empty to trigger build
n0tl3ss 7b824f2
empty to trigger build
n0tl3ss b37d6ce
empty to trigger build
n0tl3ss fead6f1
experiment
n0tl3ss 935d320
experiment
n0tl3ss d1a570d
experiment
n0tl3ss d6ed7f9
experiment
n0tl3ss 993aa7e
experiment
n0tl3ss 1ad1521
experiment
n0tl3ss 5b79bbb
empty to trigger build
n0tl3ss 076e720
experiment
n0tl3ss d22a149
empty to trigger build
n0tl3ss dc9086b
empty to trigger build
n0tl3ss 3ae5682
empty to trigger build
n0tl3ss d007bc0
empty to trigger build
n0tl3ss 26bd73d
empty to trigger build
n0tl3ss e4db018
experiment
n0tl3ss 1ce9dde
empty to trigger build
n0tl3ss 0898712
empty to trigger build
n0tl3ss c6ba6a1
experiment
n0tl3ss e597432
experiment
n0tl3ss 66b8c70
experiment
n0tl3ss 0527124
experiment
n0tl3ss ba6355b
experiment
n0tl3ss a9ac47f
empty to trigger build
n0tl3ss 0664874
empty to trigger build
n0tl3ss 5ad1cb3
experiment
n0tl3ss 5475d0b
experiment
n0tl3ss 92a7d36
experiment
n0tl3ss c93a538
empty to trigger build
n0tl3ss 8911f84
empty to trigger build
n0tl3ss a4d5040
empty to trigger build
n0tl3ss 11c1938
empty to trigger build
n0tl3ss 0f6381a
empty to trigger build
n0tl3ss 18262ad
empty to trigger build
n0tl3ss db6a9ef
empty to trigger build
n0tl3ss 455e4ad
empty to trigger build
n0tl3ss b3106bc
experiment
n0tl3ss e0cfdd6
experiment
n0tl3ss 85a2935
experiment
n0tl3ss 497c05a
empty to trigger build
n0tl3ss a34182b
experiment
n0tl3ss ed437b2
experiment
n0tl3ss b49976e
experiment
n0tl3ss bdcecba
experiment
n0tl3ss 4429ca5
experiment
n0tl3ss 60e062d
empty to trigger build
n0tl3ss 90a04f8
empty to trigger build
n0tl3ss a665496
empty to trigger build
n0tl3ss 3ef1e95
empty to trigger build
n0tl3ss 8570bc9
Merge branch 'master' into feature/workflow1
n0tl3ss ef7bf77
fix SecretInformerControllerSpec test
n0tl3ss 97e8605
empty to trigger build
n0tl3ss e464019
empty to trigger build
n0tl3ss bb47f68
empty to trigger build
n0tl3ss 25a7f3c
Merge branch 'master' into feature/workflow1
n0tl3ss 052c3cf
empty to trigger build
n0tl3ss 3259495
empty to trigger build
n0tl3ss a67bc50
empty to trigger build
n0tl3ss fa33222
remove shared
n0tl3ss d2844be
remove shared
n0tl3ss d9dd6c0
empty to trigger build
n0tl3ss d8eee57
empty to trigger build
n0tl3ss 0b35ef6
empty to trigger build
n0tl3ss e0a78ff
empty to trigger build
n0tl3ss 81c8ef4
empty to trigger build
n0tl3ss 8a2ec95
empty to trigger build
n0tl3ss e78e2b0
empty to trigger build
n0tl3ss 17d661e
empty to trigger build
n0tl3ss 6cfa8e7
Merge branch 'master' into feature/workflow1
n0tl3ss fecfc62
update KubernetesSpecification
n0tl3ss 059e8c1
empty to trigger build
n0tl3ss 06326e6
empty to trigger build
n0tl3ss 67e24a5
empty to trigger build
n0tl3ss 75d2240
empty to trigger build
n0tl3ss ade3eb1
empty to trigger build
n0tl3ss 04bc347
empty to trigger build
n0tl3ss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,39 +17,59 @@ jobs: | |
| build: | ||
| if: github.repository != 'micronaut-projects/micronaut-project-template' | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| OCI_CLI_USER: ${{ secrets.OCI_USER }} | ||
| OCI_CLI_TENANCY: ${{ secrets.OCI_TENANCY }} | ||
| OCI_CLI_FINGERPRINT: ${{ secrets.OCI_FINGERPRINT }} | ||
| OCI_CLI_KEY_CONTENT: ${{ secrets.OCI_KEY_FILE }} | ||
| OCI_CLI_REGION: ${{ secrets.OCI_REGION }} | ||
| strategy: | ||
| matrix: | ||
| java: [ '17' ] | ||
| graalvm: ['latest'] | ||
| k8s: [ '1.21' ] | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Configure Kubectl | ||
| uses: oracle-actions/[email protected] | ||
| id: test-configure-kubectl-oke-action | ||
| with: | ||
| cluster: ${{ secrets.OKE_CLUSTER_OCID }} | ||
| - name: Run Kubectl | ||
| run: kubectl get nodes -A | ||
| - name: Pre-build | ||
| uses: ./.github/actions/gradle-pre-build | ||
| uses: ./.github/actions/graalvm-pre-build | ||
| id: pre-build | ||
| env: | ||
| K8S_VERSION: ${{ matrix.k8s }} | ||
| GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }} | ||
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GRADLE_ENTERPRISE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }} | ||
| GIT_COMMIT_HASH: ${{ github.sha }} | ||
| OCI_REGION: ${{ secrets.OCI_REGION }} | ||
| JOB_ID: ${{ format('{0}-graalvm-java-{1}', github.run_id, matrix.java) }} | ||
| OCI_TENANCY_NAME: ${{ secrets.OCI_TENANCY_NAME }} | ||
alvarosanchez marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| JAVA_VERSION: ${{ matrix.java }} | ||
| AUTH_TOKEN: ${{ secrets.OCI_AUTH_TOKEN }} | ||
| OCIR_USERNAME: ${{ secrets.OCIR_USERNAME }} | ||
alvarosanchez marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| with: | ||
| java: ${{ matrix.java }} | ||
| graalvm: ${{ matrix.graalvm }} | ||
| - name: Build | ||
| uses: ./.github/actions/graalvm-build | ||
| id: build | ||
| with: | ||
| java: ${{ matrix.java }} | ||
| env: | ||
| GH_TOKEN_PUBLIC_REPOS_READONLY: ${{ secrets.GH_TOKEN_PUBLIC_REPOS_READONLY }} | ||
| GH_USERNAME: ${{ secrets.GH_USERNAME }} | ||
| GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }} | ||
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GRADLE_ENTERPRISE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }} | ||
| IMAGE_TAG: 'java-${{ matrix.java }}-${{ github.sha }}' | ||
| IMAGE_PREFIX: '${{ secrets.OCI_REGION }}.ocir.io/${{ secrets.OCI_TENANCY_NAME }}/' | ||
| KUBERNETES_TRUST_CERTIFICATES: 'true' | ||
| - name: Post-build | ||
| uses: ./.github/actions/graalvm-post-build | ||
| if: always() | ||
| id: post-build | ||
| env: | ||
| K8S_VERSION: ${{ matrix.k8s }} | ||
| JOB_ID: ${{ format('{0}-graalvm-java-{1}', github.run_id, matrix.java) }} | ||
| with: | ||
| java: ${{ matrix.java }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,36 +17,55 @@ jobs: | |
| build: | ||
| if: github.repository != 'micronaut-projects/micronaut-project-template' | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| OCI_CLI_USER: ${{ secrets.OCI_USER }} | ||
| OCI_CLI_TENANCY: ${{ secrets.OCI_TENANCY }} | ||
| OCI_CLI_FINGERPRINT: ${{ secrets.OCI_FINGERPRINT }} | ||
| OCI_CLI_KEY_CONTENT: ${{ secrets.OCI_KEY_FILE }} | ||
| OCI_CLI_REGION: ${{ secrets.OCI_REGION }} | ||
| strategy: | ||
| matrix: | ||
| java: ['8', '11', '17'] | ||
| k8s: ['1.21'] | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Configure Kubectl | ||
| uses: oracle-actions/[email protected] | ||
| id: test-configure-kubectl-oke-action | ||
| with: | ||
| cluster: ${{ secrets.OKE_CLUSTER_OCID }} | ||
| - name: Run Kubectl | ||
| run: kubectl get nodes -A | ||
| - name: Pre-build | ||
| uses: ./.github/actions/gradle-pre-build | ||
| id: pre-build | ||
| env: | ||
| K8S_VERSION: ${{ matrix.k8s }} | ||
| GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }} | ||
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GRADLE_ENTERPRISE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }} | ||
| OCI_REGION: ${{ secrets.OCI_REGION }} | ||
| OCI_TENANCY_NAME: ${{ secrets.OCI_TENANCY_NAME }} | ||
| AUTH_TOKEN: ${{ secrets.OCI_AUTH_TOKEN }} | ||
| OCIR_USERNAME: ${{ secrets.OCIR_USERNAME }} | ||
| GIT_COMMIT_HASH: ${{ github.sha }} | ||
| JOB_ID: ${{ format('{0}-java-{1}', github.run_id, matrix.java) }} | ||
| JAVA_VERSION: ${{ matrix.java }} | ||
| with: | ||
| java: ${{ matrix.java }} | ||
| - name: Build | ||
| uses: ./.github/actions/gradle-build | ||
| id: build | ||
| with: | ||
| java: ${{ matrix.java }} | ||
| env: | ||
| GH_TOKEN_PUBLIC_REPOS_READONLY: ${{ secrets.GH_TOKEN_PUBLIC_REPOS_READONLY }} | ||
| GH_USERNAME: ${{ secrets.GH_USERNAME }} | ||
| GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }} | ||
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GRADLE_ENTERPRISE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }} | ||
| IMAGE_TAG: 'java-${{ matrix.java }}-${{ github.sha }}' | ||
| IMAGE_PREFIX: '${{ secrets.OCI_REGION }}.ocir.io/${{ secrets.OCI_TENANCY_NAME }}/' | ||
| KUBERNETES_TRUST_CERTIFICATES: 'true' | ||
| - name: Post-build | ||
| uses: ./.github/actions/gradle-post-build | ||
| id: post-build | ||
| if: always() | ||
| env: | ||
| GH_TOKEN_PUBLIC_REPOS_READONLY: ${{ secrets.GH_TOKEN_PUBLIC_REPOS_READONLY }} | ||
| GH_USERNAME: ${{ secrets.GH_USERNAME }} | ||
|
|
@@ -56,7 +75,7 @@ jobs: | |
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GRADLE_ENTERPRISE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }} | ||
| GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||
| K8S_VERSION: ${{ matrix.k8s }} | ||
| JOB_ID: ${{ format('{0}-java-{1}', github.run_id, matrix.java) }} | ||
| with: | ||
| java: ${{ matrix.java }} | ||
| - name: Publish-Github-Pages | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,12 @@ on: | |
| jobs: | ||
| build: | ||
| if: github.repository != 'micronaut-projects/micronaut-project-template' | ||
| env: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI this workflow is being removed since we are running coverage in the main Gradle workflow. See micronaut-projects/micronaut-project-template#342 |
||
| OCI_CLI_USER: ${{ secrets.OCI_USER }} | ||
| OCI_CLI_TENANCY: ${{ secrets.OCI_TENANCY }} | ||
| OCI_CLI_FINGERPRINT: ${{ secrets.OCI_FINGERPRINT }} | ||
| OCI_CLI_KEY_CONTENT: ${{ secrets.OCI_KEY_FILE }} | ||
| OCI_CLI_REGION: ${{ secrets.OCI_REGION }} | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| # https://github.com/actions/virtual-environments/issues/709 | ||
|
|
@@ -39,11 +45,25 @@ jobs: | |
| with: | ||
| distribution: 'adopt' | ||
| java-version: 11 | ||
| - name: Configure Kubectl | ||
| uses: oracle-actions/[email protected] | ||
| id: test-configure-kubectl-oke-action | ||
| with: | ||
| cluster: ${{ secrets.OKE_CLUSTER_OCID }} | ||
| - name: Run Kubectl | ||
| run: kubectl get nodes -A | ||
| - name: Optional setup step | ||
| env: | ||
| GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }} | ||
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GRADLE_ENTERPRISE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }} | ||
| GIT_COMMIT_HASH: ${{ github.sha }} | ||
| JOB_ID: ${{ format('{0}-sonar', github.run_id) }} | ||
| OCI_REGION: ${{ secrets.OCI_REGION }} | ||
| OCI_TENANCY_NAME: ${{ secrets.OCI_TENANCY_NAME }} | ||
| JAVA_VERSION: '11' | ||
| AUTH_TOKEN: ${{ secrets.OCI_AUTH_TOKEN }} | ||
| OCIR_USERNAME: ${{ secrets.OCIR_USERNAME }} | ||
| run: | | ||
| [ -f ./setup.sh ] && ./setup.sh || true | ||
| - name: Analyse with Gradle | ||
|
|
@@ -54,5 +74,17 @@ jobs: | |
| GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }} | ||
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GRADLE_ENTERPRISE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }} | ||
| IMAGE_TAG: 'java-11-${{ github.sha }}' | ||
| IMAGE_PREFIX: '${{ secrets.OCI_REGION }}.ocir.io/${{ secrets.OCI_TENANCY_NAME }}/' | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| KUBERNETES_TRUST_CERTIFICATES: 'true' | ||
| - name: Optional teardown step | ||
| if: always() | ||
| env: | ||
| GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }} | ||
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GRADLE_ENTERPRISE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }} | ||
| JOB_ID: ${{ format('{0}-sonar', github.run_id) }} | ||
| run: | | ||
| [ -f ./teardown.sh ] && ./teardown.sh || true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,7 +1,9 @@ | ||||||||||||
| package micronaut.client | ||||||||||||
|
|
||||||||||||
| import groovy.util.logging.Slf4j | ||||||||||||
| import io.micronaut.context.annotation.Property | ||||||||||||
| import io.micronaut.context.env.Environment | ||||||||||||
| import io.micronaut.core.util.StringUtils | ||||||||||||
| import io.micronaut.http.annotation.Get | ||||||||||||
| import io.micronaut.http.client.annotation.Client | ||||||||||||
| import io.micronaut.kubernetes.test.KubernetesSpecification | ||||||||||||
|
|
@@ -17,13 +19,18 @@ import io.micronaut.context.annotation.Requires as MicronautRequires | |||||||||||
| @MicronautTest(environments = Environment.KUBERNETES) | ||||||||||||
| @Property(name = "spec.name", value = "KubernetesHealthIndicatorSpec") | ||||||||||||
| @Property(name = "spec.reuseNamespace", value = "false") | ||||||||||||
| @Property(name = "kubernetes.client.namespace", value = "kubernetes-health-indicator") | ||||||||||||
| @Requires({ TestUtils.kubernetesApiAvailable() }) | ||||||||||||
| @Slf4j | ||||||||||||
| class KubernetesHealthIndicatorSpec extends KubernetesSpecification { | ||||||||||||
|
|
||||||||||||
| @Inject | ||||||||||||
| @Shared | ||||||||||||
| ServiceClient client | ||||||||||||
|
|
||||||||||||
| @Property(name = "image.tag") | ||||||||||||
| String imageTag | ||||||||||||
|
|
||||||||||||
| def setupSpec() { | ||||||||||||
| operations.portForwardService("example-service", namespace, 8081, 9999) | ||||||||||||
| } | ||||||||||||
|
|
@@ -32,6 +39,11 @@ class KubernetesHealthIndicatorSpec extends KubernetesSpecification { | |||||||||||
| when: | ||||||||||||
| Map details = client.health().details | ||||||||||||
|
|
||||||||||||
| String tagName = "latest" | ||||||||||||
| if (StringUtils.isNotEmpty(imageTag)) { | ||||||||||||
| tagName = imageTag | ||||||||||||
| } | ||||||||||||
|
||||||||||||
| String tagName = "latest" | |
| if (StringUtils.isNotEmpty(imageTag)) { | |
| tagName = imageTag | |
| } | |
| String tagName = imageTag ?: "latest" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the action to use
OCI_CLI_REGIONinstead?