Skip to content

Fix condition in web metrics server and client filters#1054

Open
n0tl3ss wants to merge 4 commits into
5.13.xfrom
fix-typo-in-web-metrics-server-condition
Open

Fix condition in web metrics server and client filters#1054
n0tl3ss wants to merge 4 commits into
5.13.xfrom
fix-typo-in-web-metrics-server-condition

Conversation

@n0tl3ss

@n0tl3ss n0tl3ss commented Oct 28, 2025

Copy link
Copy Markdown
Member

Refine WebMetricsServerCondition so HTTP server metrics are not disabled when the Observation HTTP module is missing. The condition now:

  • Falls back to the Micrometer-based ServerMetricsFilter/ClientMetricsFilter whenever ObservationServerFilter/ObservationClientFilter is not on the classpath
  • Keeps mutual exclusivity when the observation module is present (enabled by default; creates ServerMetricsFilter/ClientMetricsFilter only when explicitly disabled)

No API changes; behavior fix only. Core tests are green and the guide now documents the server/client filter selection/fallback.

@n0tl3ss n0tl3ss changed the title Fix typo in web metrics server condition Fix typo in web metrics server and client condition Oct 28, 2025
@n0tl3ss n0tl3ss changed the title Fix typo in web metrics server and client condition Fix condition in web metrics server and client condition Oct 28, 2025
@n0tl3ss n0tl3ss changed the title Fix condition in web metrics server and client condition Fix condition in web metrics server and client filters Oct 28, 2025
@sonarqubecloud

Copy link
Copy Markdown

@sdelamo sdelamo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you target 6.1.x branch as the PR base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants