Support client certificate refresh from certificate service #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Oracle Cloud CI 17 latest failed: https://ge.micronaut.io/s/eyg3j26x2vgvg |
|
❌ Oracle Cloud CI 17 latest failed: https://ge.micronaut.io/s/q42vyonlhjff6 |
|
❌ Oracle Cloud CI 17 latest failed: https://ge.micronaut.io/s/vip5g34eg42wq |
|
❌ Oracle Cloud CI 17 latest failed: https://ge.micronaut.io/s/k3q7yhmbbqpck |
|
❌ Oracle Cloud CI 17 latest failed: https://ge.micronaut.io/s/z7fzicdup5t5w |
|
❌ Oracle Cloud CI 17 latest failed: |
1 similar comment
|
❌ Oracle Cloud CI 17 latest failed: |
graemerocher
commented
Sep 29, 2025
buildSrc/src/main/groovy/io.micronaut.build.internal.oraclecloud-base.gradle
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/io.micronaut.build.internal.ocisdk-metadata-module.gradle
Outdated
Show resolved
Hide resolved
oraclecloud-certificates/src/main/java/io/micronaut/http/ssl/OracleCloudCertificateFetcher.java
Outdated
Show resolved
Hide resolved
oraclecloud-certificates/src/main/java/io/micronaut/http/ssl/OracleCloudCertificateFetcher.java
Outdated
Show resolved
Hide resolved
oraclecloud-certificates/src/main/java/io/micronaut/http/ssl/OracleCloudCertificateFetcher.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/micronaut/oraclecloud/certificates/ssl/OracleCloudCertificateProvider.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Sep 29, 2025
.../main/java/io/micronaut/oraclecloud/certificates/services/OracleCloudCertificateFetcher.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Sep 29, 2025
oraclecloud-certificates/src/main/java/io/micronaut/http/ssl/OracleCloudCertificateFetcher.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Sep 29, 2025
oraclecloud-certificates/src/main/java/io/micronaut/http/ssl/OracleCloudCertificateFetcher.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Sep 29, 2025
oraclecloud-certificates/src/main/java/io/micronaut/http/ssl/OracleCloudCertificateFetcher.java
Outdated
Show resolved
Hide resolved
…racleCloudCertificateFetcher.java Co-authored-by: Jonas Konrad <[email protected]>
yawkat
reviewed
Sep 29, 2025
| @NonNull String certificateId, | ||
| @Nullable Long versionNumber, | ||
| @Nullable String certificateVersionName, | ||
| @Nullable Boolean enabled |
There was a problem hiding this comment.
I think you can use bindable to give a default instead of making this nullable
yawkat
reviewed
Sep 29, 2025
...n/java/io/micronaut/oraclecloud/certificates/config/OracleCloudCertificateConfiguration.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Sep 29, 2025
...main/java/io/micronaut/oraclecloud/certificates/config/OracleCloudCertificateProperties.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Sep 29, 2025
| @Requires(classes = {Certificates.class}) | ||
| @Requires(beans = {Certificates.class}) | ||
| @Requires(property = OracleCloudCertificationsConfiguration.PREFIX + ".enabled", value = "true") | ||
| @Internal |
yawkat
reviewed
Sep 29, 2025
...s/src/main/java/io/micronaut/oraclecloud/certificates/ssl/OracleCloudCertificateFactory.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Sep 29, 2025
.../src/main/java/io/micronaut/oraclecloud/certificates/ssl/OracleCloudCertificateProvider.java
Outdated
Show resolved
Hide resolved
|
❌ Oracle Cloud CI 17 latest failed: |
|
❌ Oracle Cloud CI 17 latest failed: |
yawkat
reviewed
Sep 30, 2025
...in/java/io/micronaut/oraclecloud/certificates/config/CertificateClientContextConfigurer.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Sep 30, 2025
...n/java/io/micronaut/oraclecloud/certificates/config/OracleCloudCertificateConfiguration.java
Outdated
Show resolved
Hide resolved
yawkat
reviewed
Sep 30, 2025
.../main/java/io/micronaut/oraclecloud/certificates/OracleCloudCertificationsConfiguration.java
Outdated
Show resolved
Hide resolved
|
❌ Oracle Cloud CI 17 latest failed: |
yawkat
reviewed
Oct 1, 2025
| public void configure(ApplicationContextBuilder builder) { | ||
| System.setProperty(Environment.BOOTSTRAP_CONTEXT_PROPERTY, StringUtils.TRUE); | ||
| builder.properties(Map.of( | ||
| "oci.clients.certificates.ssl.enabled", "true" |
There was a problem hiding this comment.
this is the default, right? So why is this needed? Does it somehow prevent loading the default micronaut.http.client.ssl.key-name?
There was a problem hiding this comment.
Yes it does I added it in the doc it creates a specific config that will be used only by Certificate client
n0tl3ss
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.