logging: CPython-compatible logging improvements #750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ned-pcs
force-pushed
the
ned-pcs/fix-logging-handlers
branch
from
e028c48
to
30d1a46
Compare
ned-pcs
force-pushed
the
ned-pcs/fix-logging-handlers
branch
from
30d1a46
to
dfdc686
Compare
This commit allows for logging handlers to be added to the root logger
and then used by non-root loggers that don't have their own handlers.
It also adds the (CPython-compatible) handlers argument
to logging.basicConfig() to ease this initialization:
import logging
sh = logging.StreamHandler()
fh = logging.FileHandler("my.log", mode="a")
logging.basicConfig(handlers=[sh, fh])
root_logger = logging.getLogger() # uses sh and fh
another_logger = logging.getLogger("another") # inherits handlers
It also adds the Logger.removeHandler() method and avoids repeated handler
addition.
It also correctly calls the superclass constructor from the StreamHandler
constructor and uses a default formatter if a Handler has none
set (as in PR micropython#710).
Signed-off-by: Ned Konz <[email protected]>
ned-pcs
force-pushed
the
ned-pcs/fix-logging-handlers
branch
from
dfdc686
to
51ea39c
Compare
This commit allows for logging handlers to be added to the root logger
and then used by non-root loggers that don't have their own handlers.
It also adds the (CPython-compatible) handlers argument
to logging.basicConfig() to ease this initialization:
import logging
sh = logging.StreamHandler()
fh = logging.FileHandler("my.log", mode="a")
logging.basicConfig(handlers=[sh, fh])
root_logger = logging.getLogger() # uses sh and fh
another_logger = logging.getLogger("another") # inherits handlers
It also adds the Logger.removeHandler() method and avoids repeated handler
addition.
It also adds the flush() method to StreamHandler and its subclasses.
It also correctly calls the superclass constructor from the StreamHandler
constructor and uses a default formatter if a Handler has none
set (as in PR micropython#710).
Signed-off-by: Ned Konz <[email protected]>
|
build failure appears to be due to manifest issues unrelated to this PR. |
|
Closed; replaced with #806 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows for logging handlers to be added to the root logger and then used by non-root loggers that don't have their own handlers.
It also adds the (CPython-compatible)
handlersargument tologging.basicConfig()to ease this initialization:It also adds the
Logger.removeHandler()method and avoids repeated handler addition.It also correctly calls the superclass constructor from the
StreamHandlerconstructor and uses a default formatter if a Handler has none set (as in PR #710).