Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Waveshare RP2040-Zero image. #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hramrach
Copy link

Signed-off-by: Michal Suchanek <[email protected]>
@mattytrentini
Copy link
Contributor

Thanks for the contribution, but perhaps we can use a better image, like one of the official Waveshare images (just needs to be cropped a little)? The image is from here. I don't think there are any licensing issues.

@hramrach
Copy link
Author

There is no license statement on the wiki I could find. On the product page the license statement is

An Waveshare Company Copyright © 2024 | All Rights Reserved.

That makes the original product image unusable.

I am not affiliated with Waveshare in any way and do not have any influence over the IP rights of their images, hence I provided a different image for which I can guarantee that it's possible to legally include in arbitrary repositories.

@mattytrentini
Copy link
Contributor

You're right to be concerned with licensing. 😄

However, I've requested to use Waveshare images in past and they've been generous in allowing them to be used. I'll make a request for the use of this image too.

@hramrach
Copy link
Author

If the official images can be used I would say this one

https://www.waveshare.com/media/catalog/product/cache/1/image/800x800/9df78eab33525d08d6e5fb8d27136e95/r/p/rp2040-zero-3.jpg

rotated 90 degrees and cropped would likely fit the board gallery on the download page.

@mattytrentini
Copy link
Contributor

OK, I thought this sounded familiar. The previous Waveshare image I requested permission for was also an RP2040-Zero! It turns out there are already board definition (micropython/micropython#13313) and image PRs (#56) open for this board. In fact, there is another pair of board definition (micropython/micropython#9085) and images (#62) also submitted!

Three pairs of PRs for boards and images for the RP2040-Zero; it must be a popular board!

We'll need to review them all.

@hramrach
Copy link
Author

I have another board from Waveshare which seems 100% compatible with Pico, this one is interesting only in that it has the RGB led which is probably worth mentioning in the board description. Other than that the Pico firmware should work unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants