ble_hs_stop.c: Prevent duplicate entries in ble_hs_stop_listeners. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under circumstances not fully clear sometimes duplicate list elements are added to the `list ble_hs_stop_listeners`. If that happens, the function `ble_hs_stop_done()` never terminates. This PR adds a check into `ble_hs_stop_register_listener()` if a to-be-added node/sublist already exist in the list and the it does not add this element. While this is anyhow a good test, it should not be needed in the MicroPython environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under circumstances not fully clear sometimes duplicate list elements are added to the
list ble_hs_stop_listeners. If that happens, the functionble_hs_stop_done()never terminates.This PR adds a check into
ble_hs_stop_register_listener()if a to-be-added node/sublist already exist in the list and the it does not add this element. While this is anyhow a good test, it should not be needed in the MicroPython environment.