-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supported properties to AC object models #8895
Open
RichardLun
wants to merge
5
commits into
microsoft:main
Choose a base branch
from
RichardLun:users/richardlun/add-model-fields
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
using Newtonsoft.Json; | ||
using System.Collections.Generic; | ||
using System.Xml.Serialization; | ||
|
||
namespace AdaptiveCards | ||
{ | ||
/// <summary> | ||
/// Represents the Action.Http element. | ||
/// </summary> | ||
#if !NETSTANDARD1_3 | ||
[XmlType(TypeName = AdaptiveHttpAction.TypeName)] | ||
#endif | ||
public class AdaptiveHttpAction : AdaptiveAction | ||
{ | ||
/// <inheritdoc /> | ||
public const string TypeName = "Action.Http"; | ||
|
||
/// <inheritdoc /> | ||
#if !NETSTANDARD1_3 | ||
[XmlIgnore] | ||
#endif | ||
public override string Type { get; set; } = TypeName; | ||
|
||
/// <summary> | ||
/// Http method. | ||
/// </summary> | ||
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)] | ||
#if !NETSTANDARD1_3 | ||
[XmlAttribute] | ||
#endif | ||
public string Method { get; set; } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this just GET/POST? |
||
|
||
/// <summary> | ||
/// Target url for request. | ||
/// </summary> | ||
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)] | ||
#if !NETSTANDARD1_3 | ||
[XmlAttribute] | ||
#endif | ||
public string Url { get; set; } | ||
|
||
/// <summary> | ||
/// Body of request. | ||
/// </summary> | ||
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)] | ||
#if !NETSTANDARD1_3 | ||
[XmlAttribute] | ||
#endif | ||
public string Body { get; set; } | ||
|
||
/// <summary> | ||
/// List of headers. | ||
/// </summary> | ||
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)] | ||
#if !NETSTANDARD1_3 | ||
[XmlAttribute] | ||
#endif | ||
public List<AdaptiveHttpHeader> Headers { get; set; } | ||
|
||
/// <summary> | ||
/// Adds a <see cref="AdaptiveHttpHeader" /> to the AdaptiveHttpAction. | ||
/// </summary> | ||
public void AddHttpHeader(AdaptiveHttpHeader header) | ||
{ | ||
this.Headers ??= new List<HttpHeader>(); | ||
this.Headers.Add(httpHeader); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
using Newtonsoft.Json; | ||
using System; | ||
using System.ComponentModel; | ||
using System.Xml.Serialization; | ||
|
||
namespace AdaptiveCards | ||
{ | ||
/// <summary> | ||
/// Represents the AdaptiveHttpHeader. | ||
/// </summary> | ||
public class AdaptiveHttpHeader | ||
{ | ||
/// <summary> | ||
/// Initializes <see cref="AdaptiveHttpHeader"/>. | ||
/// </summary> | ||
public AdaptiveHttpHeader(string name, string value) | ||
{ | ||
Name = name; | ||
Value = value; | ||
} | ||
|
||
/// <summary> | ||
/// Gets or sets the header name. | ||
/// </summary> | ||
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)] | ||
#if !NETSTANDARD1_3 | ||
[XmlAttribute] | ||
#endif | ||
public string Name { get; set; } | ||
|
||
/// <summary> | ||
/// Gets or sets the header value. | ||
/// </summary> | ||
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)] | ||
#if !NETSTANDARD1_3 | ||
[XmlAttribute] | ||
#endif | ||
public string Value { get; set; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
using Newtonsoft.Json; | ||
using System; | ||
using System.ComponentModel; | ||
using System.Xml.Serialization; | ||
|
||
namespace AdaptiveCards | ||
{ | ||
/// <summary> | ||
/// Represents padding object. | ||
/// </summary> | ||
public class AdaptivePadding | ||
{ | ||
/// <summary> | ||
/// Initializes <see cref="AdaptivePadding"/>. | ||
/// </summary> | ||
public AdaptivePadding(AdaptiveSpacing left, AdaptiveSpacing top, AdaptiveSpacing right, AdaptiveSpacing bottom) | ||
{ | ||
Left = left; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it expected to have different paddings for all directions? I think later implementation versions only allow a single value |
||
Right = right; | ||
Top = top; | ||
Bottom = bottom; | ||
} | ||
|
||
/// <summary> | ||
/// Initializes <see cref="AdaptivePadding"/>. | ||
/// </summary> | ||
public AdaptivePadding(AdaptiveSpacing padding) | ||
{ | ||
Left = Right = Top = Bottom = padding; | ||
} | ||
|
||
/// <summary> | ||
/// Gets or sets the left padding. | ||
/// </summary> | ||
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)] | ||
#if !NETSTANDARD1_3 | ||
[XmlAttribute] | ||
#endif | ||
public AdaptiveSpacing Left { get; set; } | ||
|
||
/// <summary> | ||
/// Gets or sets the right padding. | ||
/// </summary> | ||
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)] | ||
#if !NETSTANDARD1_3 | ||
[XmlAttribute] | ||
#endif | ||
public AdaptiveSpacing Right { get; set; } | ||
|
||
/// <summary> | ||
/// Gets or sets the top padding. | ||
/// </summary> | ||
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)] | ||
#if !NETSTANDARD1_3 | ||
[XmlAttribute] | ||
#endif | ||
public AdaptiveSpacing Top { get; set; } | ||
|
||
/// <summary> | ||
/// Gets or sets the bottom padding. | ||
/// </summary> | ||
[JsonProperty(NullValueHandling = NullValueHandling.Ignore)] | ||
#if !NETSTANDARD1_3 | ||
[XmlAttribute] | ||
#endif | ||
public AdaptiveSpacing Bottom { get; set; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have any examples about what this Originator should look like? what is this value used for?