Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trusted types policy names to remove 'allow-duplicated' #9050

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Farcemolina
Copy link
Collaborator

Description

In OWA we have 2 dependencies from adaptivecards (v1 and v3), since they both have the same trusted types policies names, we need them to be different so we can remove the 'allow-duplicates' from the CSP for better security and clearance when defining the list of allowed policies.

How Verified

This is not going to change any functionality, just the name of the policies for reference

@@ -1132,7 +1132,7 @@ export class TextBlock extends BaseTextBlock {
// Markdown processing is handled outside of Adaptive Cards. It's up to the host to ensure that markdown is safely
// processed.
private static readonly _ttMarkdownPolicy = (typeof window === 'undefined') ? undefined : window.trustedTypes?.createPolicy(
"adaptivecards#markdownPassthroughPolicy",
"adaptivecards#markdownPassthroughTrustedTypesPolicy",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwoo-msft @paulcam206 Would this have an impact on other AC users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants