Fix vercel sample to use auth from env #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Vercel SDK sample agent to properly load authentication configuration from environment variables, aligning it with the standard pattern used in other Agent 365 Node.js samples.
Key Changes:
- Replaced empty
AuthConfigurationobject withloadAuthConfigFromEnv()to load auth settings from environment variables - Added CommonJS module type declaration to package.json for proper module resolution
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nodejs/vercel-sdk/sample-agent/src/index.ts | Updated to import and use loadAuthConfigFromEnv() function for loading authentication configuration from environment variables instead of using an empty configuration object |
| nodejs/vercel-sdk/sample-agent/package.json | Added "type": "commonjs" to explicitly specify the module system |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
rbrighenti
approved these changes
Dec 2, 2025
rahuldevikar761
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
loadAuthConfigFromEnvto get the auth from the environment variables.