-
Notifications
You must be signed in to change notification settings - Fork 235
JSON Schema and Validator for Activity Protocol #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Introduces activity-protocol.schema.json for Bot Framework 3.0 activities, a C# schema validator project, and a comprehensive set of example JSON payloads for all activity types. Includes validator logic, project files, and JavaScript validation script for schema compliance testing.
|
@varuntayur please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
gurubhg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should we integrate the activity schema validation code within Microsoft.Agents.Core, where the activity schema is already implemented
- We should include a sample validator code. Additionally, can we add a Validate method directly in the activity schema implementation so that consumers can easily call it when they depend on Microsoft.Agents.Core?
- We could introduce an interface with a set of methods for validating activity messages against the schema. This would allow consumers to override the default validation logic if necessary.
- We can start with a C# and JavaScript validator, ensuring the design is flexible and easily extendable for other languages as needed.
- We can document about the validator within the schema itself and provide a reference to the validator implementation. Additionally, we could include a sample validator in the Agents repository for clarity.
Contributors: Guruprasad Bangalore