User username as VM username rather than random ID

[marrobi]

Fixes #1148 #3693

This is a PoC.

Will look to:

• Pass an object rather than individual values
• Do for other VM templates

Thoughts welcome.

[github-actions]

Unit Test Results

596 tests   594 ✅  7s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 8e8483e.

♻️ This comment has been updated with latest results.

[marrobi]

@tamirkamara @damoodamoo welcome your thoughts on this from a design perspective, got a few asks for this. Think should have a "user object":

"user": {
 "name": "blah",
 "email": "blah",
 "username": "blah" 
}

In the payload rather than how I've done it in this PR? The RP would need to understand where to look.

[tanya-borisova]

Personally, I think it's fine without a user object, as this avoids some code in the RP that would have to unpack it

[damoodamoo]

I would say it would be nicer to pass a user object rather than as individual fields, since it will only grow over time. But - not a big deal and agree with @tanya-borisova that it would mean more code in the RP.

[marrobi]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11401103181 (with refid 323e78ec)

(in response to this comment from @marrobi)