Merge pull request #1887 from microsoft/dpaul-NewRule

Don't use semicolons as line terminators enabled for code formatter.

.build/Build.ps1

@@ -91,7 +91,7 @@ $unreferencedScriptFiles = @($allScriptFiles | Where-Object {
         }
 
         return $true
-    });
+    })
 
 $unreferencedSharedScriptFiles = @($unreferencedScriptFiles | Where-Object {
         $_.StartsWith("$repoRoot\Shared\")

.build/CodeFormatterChecks/CheckScriptFileHasBOM.ps1

@@ -38,7 +38,7 @@ function CheckScriptFileHasBOM {
                     Write-Host "Added BOM: $($FileInfo.FullName)"
                     $false
                 } catch {
-                    Write-Warning "File has no BOM and couldn't be fixed automatically: $($FileInfo.FullName). Exception: $($_.Exception)";
+                    Write-Warning "File has no BOM and couldn't be fixed automatically: $($FileInfo.FullName). Exception: $($_.Exception)"
                     $true
                 }
             } else {

Admin/Find-AmbiguousSids.ps1

@@ -61,8 +61,8 @@ begin {
     Write-Host "Using GC $GCName"
     $ldapConn = New-Object System.DirectoryServices.Protocols.LdapConnection("$($GCName):3268")
     $searchReq = New-Object System.DirectoryServices.Protocols.SearchRequest("", $filter, "Subtree", $null)
-    $prc = New-Object System.DirectoryServices.Protocols.PageResultRequestControl($pageSize);
-    [void]$searchReq.Controls.Add($prc);
+    $prc = New-Object System.DirectoryServices.Protocols.PageResultRequestControl($pageSize)
+    [void]$searchReq.Controls.Add($prc)
 
     $sidProperties = @("objectSid", "sidHistory", "msExchMasterAccountSid")
     $containersToIgnore = @(",CN=WellKnown Security Principals,", ",CN=Builtin,", ",CN=ForeignSecurityPrincipals,")
@@ -99,7 +99,7 @@ process {
 
             $objectsProcessed++
         }
-    } while ($prc.Cookie.Length -gt 0);
+    } while ($prc.Cookie.Length -gt 0)
 }
 
 end {

Admin/Update-Engines.ps1

@@ -108,7 +108,7 @@ function ExtractCab($sourceCabPath, $destinationDirectory) {
         # Process each item in the cab. Determine if the destination
         # is a sub directory and create if necessary.
         for ($i=0; $i -lt $itemCount; $i++) {
-            $lastPathIndex = $source.item($i).Path.LastIndexOf("\");
+            $lastPathIndex = $source.item($i).Path.LastIndexOf("\")
 
             # If the file inside the zip file should be extracted
             # to a subfolder, then we need to reset the destination

Calendar/Check-SharingStatus.ps1

@@ -49,7 +49,7 @@ function ProcessCalendarSharingInviteLogs {
 
     # Define the header row
     $header = "Timestamp", "Mailbox", "Entry MailboxOwner", "Recipient", "RecipientType", "SharingType", "DetailLevel"
-    $csvString = @();
+    $csvString = @()
     $csvString = $header -join ","
     $csvString += "`n"
 
@@ -74,7 +74,7 @@ function ProcessCalendarSharingInviteLogs {
         return
     }
 
-    $logLines =@();
+    $logLines =@()
     # Split the output into an array of lines
     $logLines = $logOutput.MailboxLog -split "`r`n"
 
@@ -125,7 +125,7 @@ function ProcessCalendarSharingAcceptLogs {
 
     # Define the header row
     $header = "Timestamp", "Mailbox", "SharedCalendarOwner", "FolderName"
-    $csvString = @();
+    $csvString = @()
     $csvString = $header -join ","
     $csvString += "`n"
 
@@ -150,7 +150,7 @@ function ProcessCalendarSharingAcceptLogs {
         return
     }
 
-    $logLines =@();
+    $logLines =@()
     # Split the output into an array of lines
     $logLines = $logOutput.MailboxLog -split "`r`n"
 
@@ -225,7 +225,7 @@ function GetOwnerInformation {
     if ($script:OwnerMB.DisplayName -like "Redacted*") {
         Write-Host -ForegroundColor Yellow "Do Not have PII information for the Owner."
         Write-Host -ForegroundColor Yellow "Get PII Access for $($script:OwnerMB.Database)."
-        $script:PIIAccess = $false;
+        $script:PIIAccess = $false
     }
 
     Write-Host  -ForegroundColor DarkYellow  "Owner Calendar Folder Statistics:"