This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Optimization and bubble up ProducerResponseStatus #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization and bubble up ProducerResponseStatus to producer.Send method.
-Optimized DispatchSerializedData method in DefaultCallbackHandler.cs to use a single foreach method as opposed to multiple foreach statements.
-Added offset and partitionId to ProducerResponseStatus and bubbled it all the way to the producer.Send method. Kafka intended for this response to be available to the consumer for logging, health, etc.
-Added ShouldReturnOffset() unit test in DefaultCallbackHandlerTest.cs
-All Unit Tests passed