Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Optimization and bubble up ProducerResponseStatus #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jbeacham
Copy link

@jbeacham jbeacham commented May 4, 2016

Optimization and bubble up ProducerResponseStatus to producer.Send method.

-Optimized DispatchSerializedData method in DefaultCallbackHandler.cs to use a single foreach method as opposed to multiple foreach statements.
-Added offset and partitionId to ProducerResponseStatus and bubbled it all the way to the producer.Send method. Kafka intended for this response to be available to the consumer for logging, health, etc.
-Added ShouldReturnOffset() unit test in DefaultCallbackHandlerTest.cs
-All Unit Tests passed

…d method.

-Optimized DispatchSerializedData method in DefaultCallbackHandler.cs to use a single foreach method as opposed to multiple foreach statements.
-Added offset and partitionId to ProducerResponseStatus and bubbled it all the way to the producer.Send method. Kafka intended for this response to be available to the consumer for logging, health, etc.
-Added ShouldReturnOffset() unit test in DefaultCallbackHandlerTest.cs
-All Unit Tests passed
@msftclas
Copy link

msftclas commented May 4, 2016

Hi @jbeacham, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

msftclas commented May 4, 2016

@jbeacham, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@jbeacham jbeacham changed the title Optimization and bubble up the ProducerResponseStatus to producer.Sen… Optimization and bubble up ProducerResponseStatus May 4, 2016
@jbeacham
Copy link
Author

jbeacham commented May 5, 2016

I do not have access to view the Details of the AppVeyor build fail reasons. Can somebody please let me know what they say.

@mhorstma
Copy link
Contributor

mhorstma commented May 5, 2016

Your PR failed to build because of a misconfigured appveyor build project that was a result of the name change of the github project. After this failed, I cleaned out the bad appveyor build and your PR should build fine now.

@jbeacham
Copy link
Author

jbeacham commented May 5, 2016

Awesome, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants