-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Z3: optimizations for grad norm calculation and gradient clipping #5504
base: master
Are you sure you want to change the base?
Conversation
299e3b6
to
43792bb
Compare
@loadams, Yes - this optimization was already pushed and reverted due to ds-chat (failures in cpu-offload configurations). |
@nelyahu, it great that you narrowed this down. Do you think a unit test can be added for this case? |
This PR add the below functionality:
change (3) is taken from #5547 (which was closed)