-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposing some hidden CFunctionReflection members to the front end (ID3D12LibraryReflection/ID3D12FunctionReflection) #135
Open
Nielsbishere
wants to merge
27
commits into
microsoft:main
Choose a base branch
from
Oxsomi:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
4f1818f
d3d12shader.h now includes ways of retrieving more information from l…
Nielsbishere df46403
Renamed D3D12_FUNCTION_X_DESC to D3D12_X_SHADER_DESC and added it to …
Nielsbishere 918f977
Fixed compile error
Nielsbishere 5646446
Fixed formatting issue for D3D12_SHADER_DESC
Nielsbishere aa04a8b
Added missing parameters to D3D12_SHADER_DESC
Nielsbishere 9cf5d62
Now exposed D3D12_FUNCTION_DESC1 as a separate struct.
Nielsbishere 8698ca3
Added ID3D12LibraryReflection1 so ID3D12FunctionReflection1 can be qu…
Nielsbishere 47ad841
Added missing declaration of ID3D12LibraryReflection1
Nielsbishere 5c20ea3
Exposed serialized root signature to D3D12_FUNCTION_DESC1, Added GetI…
Nielsbishere 94bb304
Fixed minor formatting issue
Nielsbishere 704af69
Formatting and PR feedback
Nielsbishere 951446f
Some more minor formatting from PR feedback
Nielsbishere b180ff8
Renamed D3D12_NODE_OVERRIDES_TYPE to D3D12_NODE_LAUNCH_TYPE (PR feedb…
Nielsbishere aa7d10e
Changed ID3D12ShaderReflection's IID as noted by the comment above ID…
Nielsbishere 80dfa9f
Added ID3D12ShaderReflection1 to replace ID3D12ShaderReflection due t…
Nielsbishere 3a96f34
Mesh and amplification shaders both have numthreads too. However wave…
Nielsbishere fb6a5a3
Formatting
Nielsbishere 16a4ece
Missing interface predeclaration
Nielsbishere c9c7646
Fixed compile issue with ID3D12ShaderReflection1. Important notes: DX…
Nielsbishere e8e8634
HeapAlloc and HeapFree are duplicate defined in DXC
Nielsbishere ba69480
HeapAlloc and HeapFree is now only enabled in WinAdapter.h if DXC Win…
Nielsbishere 8cd1ddf
DXC compatibility update to allow it to update DXC-Headers since it's…
Nielsbishere bd5368b
rpc.h doesn't end with endline, which some compilers don't seem to like
Nielsbishere c002274
Merge branch of DirectX-Headers that fixes some ugly hacks
Nielsbishere 353d37a
Fixed a DEFINE_GUID problem, maybe a botched merge?
Nielsbishere 6a21463
Some wonky merges left lots of problems that are now fixed
Nielsbishere dc27951
Undid removal of #define interface, since there's definitely other st…
Nielsbishere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of breaking change made sense with the FXC model, where you linked against and shipped a redist
D3DCompiler_xx.dll
, and also makes sense with a strictly-DXC model. But in a world whereD3DCompiler_47.dll
is inbox in Windows and implements the old interface, where DXC can implement a new one, I think I'd prefer to rev this in a non-breaking way.We can do that by just adding
ID3D12ShaderReflection1
, which inherits fromID3D12ShaderReflection
and adds the new method. The VTable ofID3D12ShaderReflection1
is then identical to this new definition, except that apps can still query for the older one to avoid it being a source-breaking change for FXC consumers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay sounds good, I was planning on doing it that way, but assumed the comment was the way to do it. Guess I'lll implement it the right way.