Skip to content

Commit

Permalink
fix n test
Browse files Browse the repository at this point in the history
  • Loading branch information
jeffnn committed Jun 19, 2024
1 parent 128e6ce commit 533d564
Show file tree
Hide file tree
Showing 2 changed files with 67 additions and 4 deletions.
7 changes: 3 additions & 4 deletions lib/DxilPIXPasses/DxilAnnotateWithVirtualRegister.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ bool DxilAnnotateWithVirtualRegister::runOnModule(llvm::Module &M) {
}
unsigned int Major = 0;
unsigned int Minor = 0;
m_DM->GetDxilVersion(Major, Minor);
if (Major < 6 || (Major == 6 && Minor <= 4)) {
m_DM->GetValidatorVersion(Major, Minor);
if (Major < 1 || (Major == 1 && Minor < 4)) {
m_DM->SetValidatorVersion(1, 4);
}

Expand All @@ -149,7 +149,7 @@ bool DxilAnnotateWithVirtualRegister::runOnModule(llvm::Module &M) {
}
}

for (auto *F : instrumentableFunctions) {
for (auto* F : instrumentableFunctions) {
int InstructionRangeStart = InstNum;
int InstructionRangeEnd = InstNum;
for (auto &block : F->getBasicBlockList()) {
Expand Down Expand Up @@ -177,7 +177,6 @@ bool DxilAnnotateWithVirtualRegister::runOnModule(llvm::Module &M) {
<< printableNameSubset << "\n";
}
}

if (OSOverride != nullptr) {
// Print a set of strings of the exemplary form "InstructionCount: <n>
// <fnName>"
Expand Down
64 changes: 64 additions & 0 deletions tools/clang/test/DXC/Passes/PIX/validatorUpgrade.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
; RUN: %dxopt %s -dxil-annotate-with-virtual-regs -hlsl-dxilemit -S | FileCheck %s

; CHECK: !dx.valver = !{![[VALVER:.*]]}
; CHECK-NOT: ![[VALVER]] = !{i32 1, i32 4}


; GENERATED FROM:
; dxc -Emain -Tcs_6_1


; void main()
; {
; }



;
; Input signature:
;
; Name Index Mask Register SysValue Format Used
; -------------------- ----- ------ -------- -------- ------- ------
; no parameters
;
; Output signature:
;
; Name Index Mask Register SysValue Format Used
; -------------------- ----- ------ -------- -------- ------- ------
; no parameters
; shader hash: bcdf90f13d29df9ebdc77539089a75a6
;
; Pipeline Runtime Information:
;
; Compute Shader
; NumThreads=(1,1,1)
;
;
; Buffer Definitions:
;
;
; Resource Bindings:
;
; Name Type Format Dim ID HLSL Bind Count
; ------------------------------ ---------- ------- ----------- ------- -------------- ------
;
target datalayout = "e-m:e-p:32:32-i1:32-i8:32-i16:32-i32:32-i64:64-f16:32-f32:32-f64:64-n8:16:32:64"
target triple = "dxil-ms-dx"

define void @main() {
ret void
}

!llvm.ident = !{!0}
!dx.version = !{!1}
!dx.valver = !{!2}
!dx.shaderModel = !{!3}
!dx.entryPoints = !{!4}

!0 = !{!"dxc(private) 1.8.0.4583 (PIX_MemberFunctions, 2f4a01af1-dirty)"}
!1 = !{i32 1, i32 1}
!2 = !{i32 1, i32 8}
!3 = !{!"cs", i32 6, i32 1}
!4 = !{void ()* @main, !"main", null, null, !5}
!5 = !{i32 4, !6}
!6 = !{i32 1, i32 1, i32 1}

0 comments on commit 533d564

Please sign in to comment.