Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the layout rule explicitly for raw buffer operations #6701

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Set the layout rule explicitly for raw buffer operations #6701

merged 1 commit into from
Jun 25, 2024

Commits on Jun 18, 2024

  1. Set the layout rule explicitly for raw buffer operations 

    The first first fix in microsoft#5392 was not correct. It relied on the layout
rule for the address to be the correct layout rule, but that is not
always the case. The address is just an integer that could exist in any
storage class. The correct solution is to explicitly set the layout rule
for the BitCast operation when expanding the RawBuffer* functions. We
know that the result of the BitCast is a pointer to the physical storage
buffer storage class, so we know the layout need to be the storage
buffer layout.

Fixes microsoft#6554
    @s-perron
    s-perron committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b08ad2e View commit details
    Browse the repository at this point in the history