Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-determinism in Reassociate caused by address coincidences #6717

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix non-determinism in Reassociate caused by address coincidences #6717

merged 1 commit into from
Jun 25, 2024

Commits on Jun 24, 2024

  1. Fix non-determinism in Reassociate caused by address coincidences 

    This PR pulls the upstream change, Fix non-determinism in Reassociate caused by address coincidences (llvm/llvm-project@ef8761f), into DXC.

Here's the summary of the change:

  Between building the pair map and querying it there are a few places that erase and create Values. It's rare but the address of these newly created Values is occasionally the same as a
  just-erased Value that we already have in the pair map. These coincidences should be accounted for to avoid non-determinism.

  Thanks to Roman Tereshin for the test case.

This is part 6 (the last part) of the fix for microsoft#6659.
    @lizhengxing @adam-yang
    lizhengxing authored and adam-yang committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    07bfc26 View commit details
    Browse the repository at this point in the history