Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIR-V] Fix image write to unknown format #6984

Merged
merged 2 commits into from
Oct 28, 2024
Merged

[SPIR-V] Fix image write to unknown format #6984

merged 2 commits into from
Oct 28, 2024

Commits on Oct 24, 2024

  1. [SPIR-V] Fix image write to unknown format 

    When 'unknown' was used in vk::image_format, the value was ignored,
and a format was still guessed.

The fix revealed a bug with Write/ReadWithoutFormat capability gen:
- image formats attributes are applied as a fix-up after initial
  codegen.
- the variable is changed, but not all related operations are fixed.
- capabilities visitor assumed types were coherent, and only looked at
  the OpImageWrite/Read operand type. Not the source variable.
- legalization fixes those incoherences, but runs after the visitor.

Using the capability trimming pass for this is an easy way to solve this
issue.

One test was checking for ReadWithoutFormat, but doesn't require it
since no OpImageRead is done on a Unknown format.

Signed-off-by: Nathan Gauër <[email protected]>
    @Keenuts
    Keenuts committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    fa356d9 View commit details
    Browse the repository at this point in the history

  2. update deps 

    Signed-off-by: Nathan Gauër <[email protected]>
    @Keenuts
    Keenuts committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4738379 View commit details
    Browse the repository at this point in the history