Add a test case for record node support in tree-agent package #25452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: framework
There was a problem hiding this comment.
Pull Request Overview
This PR adds a test case for record node support in the tree-agent package and enhances type generation to include metadata descriptions for record and array node types.
- Adds a new test scenario that validates record node functionality through a user management use case
- Updates type generation to apply metadata descriptions to record and array Zod schema types
- Creates a new domain model for users to support the test case
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/framework/tree-agent/src/typeGeneration.ts | Enhanced record and array type generation to include metadata descriptions |
| packages/framework/tree-agent/src/test/scenarios/addUsers.ts | New test scenario for validating record node support with user data |
| packages/framework/tree-agent/src/test/scenarios/index.ts | Export added for the new addUsers test scenario |
| packages/framework/tree-agent/src/test/integration.spec.ts | Integration of the new addUsers test into the test suite |
| packages/framework/tree-agent/src/test/domains/users.ts | New domain model defining User and Users schema classes |
| packages/framework/tree-agent/src/test/domains/index.ts | Export added for the new Users domain model |
noencke
requested review from
taylorsw04
and removed request for
taylorsw04
taylorsw04
reviewed
Sep 13, 2025
| treeSchemaMap, | ||
| ), | ||
| ) | ||
| .describe(simpleNodeSchema.metadata?.description ?? ""); |
There was a problem hiding this comment.
Does an empty description result in an empty comment from our TypeScript type generation?
taylorsw04
approved these changes
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates type generation to include node metadata for records and arrays.