poc(data-migration): Add migration machinery to FluidDataStoreContext which swaps out entire factories #25453
+166
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copilot's summary of the change after we chatted about it a bit:
Implement one-hop, load-time datastore migration during first realization only. Old runtime instantiates, exposes migrationInfo (with portableData + newPackagePath). Context detects it, disposes old runtime without binding, swaps pkg, loads new factory via an extended migratable factory interface, instantiates new runtime with instantiateForMigration, binds it, emits telemetry, and proceeds normally. Summaries then carry new package path. Failures are fatal.
Breaking Changes
Some short-term back compat will be needed across the datastore / runtime boundary.
Reviewer Guidance
Proof of concept for now.
TODO: