Skip to content

sensei: improve azure-observability triggers and add unit/trigger/e2e tests#1019

Draft
Copilot wants to merge 5 commits intomainfrom
copilot/refactor-azure-observability
Draft

sensei: improve azure-observability triggers and add unit/trigger/e2e tests#1019
Copilot wants to merge 5 commits intomainfrom
copilot/refactor-azure-observability

Conversation

Copy link
Contributor

Copilot AI commented Feb 24, 2026

azure-observability had no unit or trigger tests, and its integration tests only checked skill invocation rather than validating real Azure Monitor scenarios. The SKILL.md description used noun-heavy triggers instead of action-verb phrases that reliably activate the skill.

SKILL.md — frontmatter

  • Replaced noun-catalog triggers with action-verb phrases: monitor my app, query logs with KQL, create alert rules, build monitoring dashboards, view distributed traces, etc.
  • Maintains Medium-High compliance (USE FOR: + DO NOT USE FOR:) with >- folded YAML format

New: unit.test.ts

  • Validates metadata compliance (description length, USE FOR/DO NOT USE FOR presence)
  • Asserts content references Azure Monitor, App Insights, Log Analytics, KQL, CLI commands, MCP tools
  • Checks frontmatter structure (no tabs, supported keys only)

New: triggers.test.ts

  • 16 "should trigger" prompts across Azure Monitor, Application Insights, Log Analytics/KQL, alerts, dashboards
  • 9 "should not trigger" prompts for unrelated/off-skill scenarios
  • Snapshot tests + edge cases (empty prompt, long prompt, case insensitivity)

Updated: integration.test.ts

Replaced skill-invocation-only tests with scenario-based e2e tests that assert domain-specific keywords appear in agent responses:

describe("azure-monitor-metrics")    → response mentions CLI/MCP commands for metrics
describe("log-analytics-kql")        → response includes KQL and Log Analytics workspace guidance  
describe("application-insights")     → response covers APM, request performance, distributed traces
describe("alert-configuration")      → response provides alert rule creation guidance
Original prompt

This section details on the original issue you should resolve

<issue_title>Revisit azure-observability</issue_title>
<issue_description>Is it useful?
If so add integration tests and run sensei</issue_description>

<agent_instructions>Refactor the skill to have triggers to it. Add integration end to end tests, not skill invocation tests to test azure monitor and other scenarios. refer azure-deploy for inspiration</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

… tests

Co-authored-by: saikoumudi <22682497+saikoumudi@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor azure observability for integration tests sensei: improve azure-observability triggers and add unit/trigger/e2e tests Feb 24, 2026
@anowardear062-svg
Copy link

This is the most important

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

🔍 Token Analysis Report

@github-copilot-for-azure/scripts@1.0.0 tokens
node --import tsx src/tokens/cli.ts compare --base origin/main --head HEAD --markdown

📊 Token Change Report

Comparing origin/mainHEAD

Summary

Metric Value
📈 Total Change +291 tokens (+28%)
Before 1,034 tokens
After 1,325 tokens
Files Changed 1

Changed Files

File Before After Change
plugin/skills/azure-observability/SKILL.md 1,034 1,325 +291 (+28%)

@github-copilot-for-azure/scripts@1.0.0 tokens
node --import tsx src/tokens/cli.ts check --markdown

📊 Token Limit Check Report

Checked: 384 files
Exceeded: 92 files

⚠️ Files Exceeding Token Limits

File Tokens Limit Over By
.github/skills/file-test-bug/SKILL.md 613 500 +113
.github/skills/sensei/README.md 3530 1000 +2530
.github/skills/sensei/SKILL.md 2216 500 +1716
.github/skills/sensei/references/EXAMPLES.md 3328 1000 +2328
.github/skills/sensei/references/LOOP.md 3717 1000 +2717
.github/skills/sensei/references/SCORING.md 2855 1000 +1855
.github/skills/sensei/references/TOKEN-INTEGRATION.md 1094 1000 +94
.github/skills/skill-authoring/SKILL.md 732 500 +232
plugin/skills/appinsights-instrumentation/SKILL.md 952 500 +452
plugin/skills/azure-ai/SKILL.md 831 500 +331
plugin/skills/azure-aigateway/SKILL.md 6324 500 +5824
plugin/skills/azure-compliance/SKILL.md 1238 500 +738
plugin/skills/azure-compliance/references/azqr-recommendations.md 1447 1000 +447
plugin/skills/azure-compliance/references/azqr-remediation-patterns.md 1987 1000 +987
plugin/skills/azure-compliance/references/azure-keyvault-expiration-audit.md 1286 1000 +286
plugin/skills/azure-compliance/references/azure-quick-review.md 1268 1000 +268
plugin/skills/azure-cost-optimization/SKILL.md 3456 500 +2956
plugin/skills/azure-deploy/SKILL.md 981 500 +481
plugin/skills/azure-deploy/references/pre-deploy-checklist.md 1195 1000 +195
plugin/skills/azure-deploy/references/recipes/azd/errors.md 1212 1000 +212
plugin/skills/azure-deploy/references/troubleshooting.md 1527 1000 +527
plugin/skills/azure-diagnostics/SKILL.md 876 500 +376
plugin/skills/azure-hosted-copilot-sdk/SKILL.md 655 500 +155
plugin/skills/azure-hosted-copilot-sdk/references/azure-model-config.md 1084 1000 +84
plugin/skills/azure-kusto/SKILL.md 2161 500 +1661
plugin/skills/azure-messaging/SKILL.md 857 500 +357
plugin/skills/azure-messaging/references/service-troubleshooting.md 1044 1000 +44
plugin/skills/azure-observability/SKILL.md 1325 500 +825
plugin/skills/azure-prepare/SKILL.md 1841 500 +1341
plugin/skills/azure-prepare/references/aspire.md 2633 1000 +1633
plugin/skills/azure-prepare/references/azure-context.md 1019 1000 +19
plugin/skills/azure-prepare/references/plan-template.md 1063 1000 +63
plugin/skills/azure-prepare/references/recipes/azd/aspire.md 1289 1000 +289
plugin/skills/azure-prepare/references/recipes/azd/azure-yaml.md 1709 1000 +709
plugin/skills/azure-prepare/references/recipes/azd/terraform.md 2924 1000 +1924
plugin/skills/azure-prepare/references/research.md 1761 1000 +761
plugin/skills/azure-prepare/references/runtimes/nodejs.md 1508 1000 +508
plugin/skills/azure-prepare/references/security.md 1784 1000 +784
plugin/skills/azure-prepare/references/services/functions/bicep.md 2116 1000 +1116
plugin/skills/azure-prepare/references/services/functions/templates/SPEC-composable-templates.md 6187 1000 +5187
plugin/skills/azure-prepare/references/services/functions/templates/recipes/README.md 1354 1000 +354
plugin/skills/azure-prepare/references/services/functions/templates/recipes/common/nodejs-entry-point.md 1034 1000 +34
plugin/skills/azure-prepare/references/services/functions/templates/recipes/common/uami-bindings.md 1223 1000 +223
plugin/skills/azure-prepare/references/services/functions/templates/recipes/composition.md 4564 1000 +3564
plugin/skills/azure-prepare/references/services/functions/templates/recipes/cosmosdb/README.md 1467 1000 +467
plugin/skills/azure-prepare/references/services/functions/templates/recipes/durable/README.md 1149 1000 +149
plugin/skills/azure-prepare/references/services/functions/templates/recipes/eventhubs/README.md 1403 1000 +403
plugin/skills/azure-prepare/references/services/functions/templates/recipes/mcp/source/java.md 1312 1000 +312
plugin/skills/azure-prepare/references/services/functions/templates/recipes/mcp/source/python.md 1207 1000 +207
plugin/skills/azure-prepare/references/services/functions/templates/recipes/mcp/source/typescript.md 1138 1000 +138
plugin/skills/azure-prepare/references/services/functions/templates/recipes/servicebus/README.md 1171 1000 +171
plugin/skills/azure-prepare/references/services/functions/templates/recipes/servicebus/source/dotnet.md 1256 1000 +256
plugin/skills/azure-prepare/references/services/functions/templates/recipes/sql/source/java.md 1009 1000 +9
plugin/skills/azure-prepare/references/services/functions/templates/recipes/sql/source/python.md 1080 1000 +80
plugin/skills/azure-prepare/references/services/functions/terraform.md 2526 1000 +1526
plugin/skills/azure-prepare/references/services/service-bus/patterns.md 1010 1000 +10
plugin/skills/azure-resource-lookup/SKILL.md 1379 500 +879
plugin/skills/azure-resource-lookup/references/azure-resource-graph.md 1307 1000 +307
plugin/skills/azure-resource-visualizer/SKILL.md 2091 500 +1591
plugin/skills/azure-storage/SKILL.md 1166 500 +666
plugin/skills/azure-storage/references/sdk-usage.md 1096 1000 +96
plugin/skills/azure-validate/SKILL.md 780 500 +280
plugin/skills/azure-validate/references/recipes/azd/README.md 1191 1000 +191
plugin/skills/entra-app-registration/SKILL.md 2055 500 +1555
plugin/skills/entra-app-registration/references/api-permissions.md 2545 1000 +1545
plugin/skills/entra-app-registration/references/cli-commands.md 2211 1000 +1211
plugin/skills/entra-app-registration/references/console-app-example.md 2752 1000 +1752
plugin/skills/entra-app-registration/references/first-app-registration.md 1846 1000 +846
plugin/skills/entra-app-registration/references/oauth-flows.md 2375 1000 +1375
plugin/skills/entra-app-registration/references/troubleshooting.md 1896 1000 +896
plugin/skills/microsoft-foundry/SKILL.md 1934 500 +1434
plugin/skills/microsoft-foundry/foundry-agent/create/create.md 3106 1000 +2106
plugin/skills/microsoft-foundry/foundry-agent/create/references/agentframework.md 1239 1000 +239
plugin/skills/microsoft-foundry/foundry-agent/deploy/deploy.md 3557 1000 +2557
plugin/skills/microsoft-foundry/foundry-agent/invoke/invoke.md 1273 1000 +273
plugin/skills/microsoft-foundry/foundry-agent/troubleshoot/troubleshoot.md 1299 1000 +299
plugin/skills/microsoft-foundry/models/deploy-model/SKILL.md 1627 500 +1127
plugin/skills/microsoft-foundry/models/deploy-model/capacity/SKILL.md 1725 500 +1225
plugin/skills/microsoft-foundry/models/deploy-model/customize/SKILL.md 2220 500 +1720
plugin/skills/microsoft-foundry/models/deploy-model/customize/references/customize-workflow.md 1859 1000 +859
plugin/skills/microsoft-foundry/models/deploy-model/preset/SKILL.md 1212 500 +712
plugin/skills/microsoft-foundry/models/deploy-model/preset/references/preset-workflow.md 4252 1000 +3252
plugin/skills/microsoft-foundry/models/deploy-model/preset/references/workflow.md 1315 1000 +315
plugin/skills/microsoft-foundry/project/create/create-foundry-project.md 1218 1000 +218
plugin/skills/microsoft-foundry/quota/references/ptu-guide.md 1473 1000 +473
plugin/skills/microsoft-foundry/quota/references/troubleshooting.md 1807 1000 +807
plugin/skills/microsoft-foundry/quota/references/workflows.md 1614 1000 +614
plugin/skills/microsoft-foundry/rbac/rbac.md 1752 1000 +752
plugin/skills/microsoft-foundry/references/sdk/foundry-sdk-py.md 1888 1000 +888
plugin/skills/microsoft-foundry/resource/create/create-foundry-resource.md 1489 1000 +489
plugin/skills/microsoft-foundry/resource/create/references/workflows.md 1637 1000 +637
.github/agents/SkillCreator.agent.md 1044 1000 +44

Consider moving content to references/ subdirectories.


Automated token analysis. See skill authoring guidelines for best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit azure-observability

3 participants