-
Notifications
You must be signed in to change notification settings - Fork 92
Create top-level AKS folder and SKILL.md #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
b10b649
8ff360f
cc20821
769631d
c37988c
0a6efd5
eb5c9a2
31523df
be258cd
295a9ed
2c1d3a2
7d79459
afc8b05
0d6e6ef
2e15f00
bd1e5e5
8d8b187
cfc9cc0
9d12083
14540ae
f6fcda1
f6dc996
453c478
0436b19
c65c53f
1bf5c35
3e578e0
9144b03
3294051
4c6c56a
02fa831
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,128 @@ | ||||||
| --- | ||||||
| name: azure-kubernetes | ||||||
| license: MIT | ||||||
| metadata: | ||||||
| author: Microsoft | ||||||
| version: "1.0.0" | ||||||
| description: "Plan and create production-ready Azure Kubernetes Service (AKS) clusters. Covers Day-0 decisions and Day-1 configuration, cluster SKUs (Automatic vs Standard), security, monitoring, reliability/performance best practices, upgrades, and networking. WHEN: create AKS cluster, plan AKS configuration, design AKS networking, AKS Automatic vs Standard, AKS security, AKS upgrade strategy, AKS autoscaling, AKS monitoring setup, AKS cost analysis, Day-0 checklist." | ||||||
| --- | ||||||
julia-yin marked this conversation as resolved.
Show resolved
Hide resolved
Comment on lines
+1
to
+8
|
||||||
|
|
||||||
| # Azure Kubernetes Service | ||||||
|
|
||||||
| > **AUTHORITATIVE GUIDANCE — MANDATORY COMPLIANCE** | ||||||
| > | ||||||
| > This skill produces a **recommended AKS cluster configuration** based on user requirements, distinguishing **Day-0 decisions** (networking, API server — hard to change later) from **Day-1 features** (can enable post-creation). See [CLI reference](./references/cli-reference.md) for commands. | ||||||
|
|
||||||
julia-yin marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| ## Quick Reference | ||||||
| | Property | Value | | ||||||
| |----------|-------| | ||||||
| | Best for | AKS cluster planning and Day-0 decisions | | ||||||
| | MCP Tools | `mcp_azure_mcp_aks`, `mcp_aks_mcp_az_aks_operations` | | ||||||
|
||||||
| | MCP Tools | `mcp_azure_mcp_aks`, `mcp_aks_mcp_az_aks_operations` | | |
| | MCP Tools | `mcp_azure_mcp_aks`, `mcp_azure_mcp_az_aks_operations` | |
Copilot
AI
Mar 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mcp_aks_mcp_az_aks_operations doesn’t appear anywhere else in the repo and doesn’t match the existing MCP tool naming pattern (mcp_azure_mcp_*). If this tool name is a typo, agents will attempt to call a non-existent tool. Please confirm the actual AKS MCP tool names and update this list accordingly.
Copilot
AI
Mar 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MCP tool names in Quick Reference (mcp_azure_mcp_aks, mcp_aks_mcp_az_aks_operations) don’t match the MCP tool naming used elsewhere in this repo (e.g., aks is referenced as the dedicated AKS MCP tool in azure-resource-lookup). These identifiers also aren’t referenced anywhere else in the repo, so they’re likely incorrect. Please align this row with the actual tool name(s) used by the AKS MCP server (or remove the row if tool support isn’t available).
Copilot
AI
Mar 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skill authoring guidelines require a dedicated MCP Tools section with a table of available MCP commands and parameters. Currently MCP tools are only listed inline in the Quick Reference table; add the required MCP Tools section/table so consumers can see which tool to call and with what parameters.
Copilot
AI
Mar 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new skill file is missing some required sections per the repo’s SKILL authoring guidelines: there should be a dedicated MCP Tools section (with a table of commands/parameters) and an Error Handling section (table of common errors, messages, remediation). Adding these sections will keep the skill consistent with other Azure skills and improve agent behavior.
Copilot
AI
Mar 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This SKILL.md doesn’t follow the repository’s Skill File Authoring Guidelines required section structure (Quick Reference, When to Use This Skill, MCP Tools, Workflow/Steps, Error Handling). Please restructure the document to include those sections/tables so it’s consistent with other plugin skills and easier to scan.
Copilot
AI
Feb 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule 2 refers to an "AKS MCP server", but repo MCP config only defines a generic azure MCP server (plugin/.mcp.json). This will lead agents to look for a non-existent server; please update the rule to reference the Azure MCP server and the relevant AKS-related MCP tools (or CLI) explicitly.
| 2. Use the AKS MCP server for invoking Azure API and kubectl commands when applicable during the cluster setup and operations processes. | |
| 2. Use the `azure` MCP server and its AKS-related MCP tools to invoke Azure APIs and perform AKS and kubectl operations whenever possible during cluster setup and ongoing operations; if required functionality is not available via MCP tools, fall back to Azure CLI and kubectl commands. |
Copilot
AI
Mar 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The skill authoring guidelines require an explicit MCP Tools section with a table of available commands + parameters. This skill only lists MCP tools in Quick Reference, which makes it hard for agents to know what to call and with which parameters. Add a dedicated ## MCP Tools section (table) before the workflow, consistent with other skills.
julia-yin marked this conversation as resolved.
Show resolved
Hide resolved
Copilot
AI
Mar 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing required MCP Tools section: the repo’s skill authoring guidelines require an explicit “MCP Tools” section with a table of commands/parameters (not just listing tool names in Quick Reference). See .github/instructions/skill-files.instructions.md (Required Sections #3).
julia-yin marked this conversation as resolved.
Show resolved
Hide resolved
julia-yin marked this conversation as resolved.
Show resolved
Hide resolved
julia-yin marked this conversation as resolved.
Show resolved
Hide resolved
julia-yin marked this conversation as resolved.
Show resolved
Hide resolved
Copilot
AI
Mar 4, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The skill authoring guidelines call for an Error Handling section (table of errors/messages/remediation). This SKILL.md currently ends with Guardrails/Safety but never defines expected failure modes (e.g., missing permissions, quota, unsupported SKU/region features) or what the agent should do. Add a ## Error Handling section with a small table.
Copilot
AI
Mar 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skill authoring guidelines require an Error Handling section with a table of errors/messages/remediation. This skill currently ends with Guardrails/Safety but does not define error cases or remediation steps; add the required Error Handling table.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # CLI Reference for AKS | ||
|
|
||
| ```bash | ||
| # List AKS clusters | ||
| az aks list --output table | ||
|
|
||
| # Show cluster details | ||
| az aks show --name <cluster-name> --resource-group <resource-group> | ||
|
|
||
| # Get available Kubernetes versions | ||
| az aks get-versions --location <location> --output table | ||
|
|
||
| # Create AKS Automatic cluster | ||
| az aks create --name <cluster-name> --resource-group <resource-group> --sku automatic \ | ||
| --network-plugin azure --network-plugin-mode overlay \ | ||
| --enable-oidc-issuer --enable-workload-identity | ||
|
|
||
| # Create AKS Standard cluster | ||
| az aks create --name <cluster-name> --resource-group <resource-group> \ | ||
| --node-count 3 --zones 1 2 3 \ | ||
| --network-plugin azure --network-plugin-mode overlay \ | ||
| --enable-cluster-autoscaler --min-count 1 --max-count 10 | ||
|
|
||
| # Get credentials | ||
| az aks get-credentials --name <cluster-name> --resource-group <resource-group> | ||
|
|
||
| # List node pools | ||
| az aks nodepool list --cluster-name <cluster-name> --resource-group <resource-group> --output table | ||
|
|
||
| # Enable monitoring | ||
| az aks enable-addons --name <cluster-name> --resource-group <resource-group> \ | ||
| --addons monitoring --workspace-resource-id <workspace-resource-id> | ||
| ``` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`azure-kubernetes - Trigger Tests Trigger Keywords Snapshot skill description triggers match snapshot 1`] = ` | ||
| { | ||
| "description": "Plan and create production-ready Azure Kubernetes Service (AKS) clusters. Covers Day-0 decisions and Day-1 configuration, cluster SKUs (Automatic vs Standard), security, monitoring, reliability/performance best practices, upgrades, and networking. WHEN: create AKS cluster, plan AKS configuration, design AKS networking, AKS Automatic vs Standard, AKS security, AKS upgrade strategy, AKS autoscaling, AKS monitoring setup, AKS cost analysis, Day-0 checklist.", | ||
| "extractedKeywords": [ | ||
| "aks", | ||
| "analysis", | ||
| "automatic", | ||
| "autoscaling", | ||
| "azure", | ||
| "best", | ||
| "checklist", | ||
| "cli", | ||
| "cluster", | ||
| "clusters", | ||
| "configuration", | ||
| "container", | ||
| "cost", | ||
| "covers", | ||
| "create", | ||
| "day-0", | ||
| "day-1", | ||
| "decisions", | ||
| "deploy", | ||
| "design", | ||
| "diagnostic", | ||
| "entra", | ||
| "identity", | ||
| "key vault", | ||
| "kubernetes", | ||
| "mcp", | ||
| "monitor", | ||
| "monitoring", | ||
| "networking", | ||
| "observability", | ||
| "performance", | ||
| "plan", | ||
| "practices", | ||
| "production-ready", | ||
| "reliability", | ||
| "security", | ||
| "service", | ||
| "setup", | ||
| "skus", | ||
| "standard", | ||
| "strategy", | ||
| "upgrade", | ||
| "upgrades", | ||
| "when", | ||
| ], | ||
| "name": "azure-kubernetes", | ||
| } | ||
| `; | ||
|
|
||
| exports[`azure-kubernetes - Trigger Tests Trigger Keywords Snapshot skill keywords match snapshot 1`] = ` | ||
| [ | ||
| "aks", | ||
| "analysis", | ||
| "automatic", | ||
| "autoscaling", | ||
| "azure", | ||
| "best", | ||
| "checklist", | ||
| "cli", | ||
| "cluster", | ||
| "clusters", | ||
| "configuration", | ||
| "container", | ||
| "cost", | ||
| "covers", | ||
| "create", | ||
| "day-0", | ||
| "day-1", | ||
| "decisions", | ||
| "deploy", | ||
| "design", | ||
| "diagnostic", | ||
| "entra", | ||
| "identity", | ||
| "key vault", | ||
| "kubernetes", | ||
| "mcp", | ||
| "monitor", | ||
| "monitoring", | ||
| "networking", | ||
| "observability", | ||
| "performance", | ||
| "plan", | ||
| "practices", | ||
| "production-ready", | ||
| "reliability", | ||
| "security", | ||
| "service", | ||
| "setup", | ||
| "skus", | ||
| "standard", | ||
| "strategy", | ||
| "upgrade", | ||
| "upgrades", | ||
| "when", | ||
| ] | ||
| `; |
Uh oh!
There was an error while loading. Please reload this page.