fix: prevent agent from deleting user workspace when adding MCP support #999
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -30,6 +30,8 @@ ask_user( | |||||
| - Do NOT assume user wants to delete/overwrite | ||||||
| - Do NOT proceed based on "the user asked to deploy" (deploy ≠ delete old) | ||||||
| - Do NOT batch destructive actions without individual confirmation | ||||||
| - ⛔ Do NOT delete user project directories (`rm -rf <project>`) even when adding features, converting, or migrating — use MODIFY mode to edit existing files instead | ||||||
| - ⛔ `azd init` and template commands are for NEW projects only — NEVER run on an existing workspace without explicit user confirmation | ||||||
|
There was a problem hiding this comment. This bullet is internally inconsistent: it says "template commands are for NEW projects only" but then suggests they can be run on an existing workspace with confirmation. To avoid agents treating this as a sanctioned in-place reinit, make the rule explicit (e.g., only run templates in an empty/new directory; if the user explicitly wants a re-init, do it in a separate directory after confirmation).
Suggested change
Member
There was a problem hiding this comment. Did you mean to say |
||||||
|
|
||||||
| --- | ||||||
|
|
||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,19 @@ Templates for hosting MCP (Model Context Protocol) servers on Azure Functions. | |||||
|
|
||||||
| **Indicators**: `mcp_tool_trigger`, `MCPTrigger`, `@app.mcp_tool`, project name contains "mcp" | ||||||
|
|
||||||
| > ⚠️ **Warning: Templates are for NEW projects only.** | ||||||
| > If the user has an existing Azure Functions project, do NOT use `azd init` — this will overwrite their workspace. | ||||||
| > For existing projects, use the **recipe approach** instead: [recipes/mcp/](recipes/mcp/README.md). | ||||||
| > ⛔ **NEVER run `rm -rf` or delete the user's project directory.** Destructive actions require `ask_user` confirmation — see [global-rules.md](../../../global-rules.md). | ||||||
|
There was a problem hiding this comment. The warning mixes an absolute prohibition ("NEVER run rm -rf") with a more permissive statement ("Destructive actions require ask_user confirmation"), which can be read as implying deletion becomes OK after confirmation. Consider rephrasing to keep the policy unambiguous: deleting user workspace directories is prohibited, and refer to global-rules.md only for other destructive actions that may require ask_user.
Suggested change
|
||||||
|
|
||||||
| ## When to Use Templates vs. Recipes | ||||||
|
|
||||||
| | Scenario | Action | | ||||||
| |----------|--------| | ||||||
| | **New project** — no existing code | Use `azd init -t` template below | | ||||||
| | **Existing project** — add MCP support | Use [recipes/mcp/](recipes/mcp/README.md) — modify existing files, do NOT reinitialize | | ||||||
|
|
||||||
| ## Standard MCP Templates (NEW projects only) | ||||||
|
|
||||||
| | Language | Template | | ||||||
| |----------|----------| | ||||||
|
|
@@ -13,13 +25,13 @@ Templates for hosting MCP (Model Context Protocol) servers on Azure Functions. | |||||
| | C# (.NET) | `azd init -t remote-mcp-functions-dotnet` | | ||||||
| | Java | `azd init -t remote-mcp-functions-java` | | ||||||
|
|
||||||
| ## MCP + API Management (OAuth) (NEW projects only) | ||||||
|
|
||||||
| | Language | Template | | ||||||
| |----------|----------| | ||||||
| | Python | `azd init -t remote-mcp-apim-functions-python` | | ||||||
|
|
||||||
| ## Self-Hosted MCP SDK (NEW projects only) | ||||||
|
|
||||||
| | Language | Template | | ||||||
| |----------|----------| | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule #8 states templates/
azd initare for new projects only, while global-rules.md currently allowsazd initon existing workspaces with explicit confirmation. Align the wording across these documents so the agent doesn’t get conflicting guidance about whether in-place initialization is ever acceptable.