Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: rename the video name when test device count is 1 #659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bugfix: rename the video name when test device count is 1 #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions agent/src/main/java/com/microsoft/hydralab/agent/runner/TestRunDeviceOrchestrator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,18 +128,18 @@ public void startScreenRecorder(@NotNull TestRunDevice testRunDevice, @NotNull F
}

public String stopScreenRecorder(@NotNull TestRunDevice testRunDevice, @NotNull File folder, @Nullable Logger logger) {
List<String> videoFilePaths = new ArrayList<>();
if (testRunDevice instanceof TestRunDeviceCombo) {
List<String> videoFilePaths = new ArrayList<>();
((TestRunDeviceCombo) testRunDevice).getDevices().forEach(testRunDevice1 -> {
String path = testRunDevice1.getScreenRecorder().finishRecording();
if (path != null && !path.isEmpty()) {
videoFilePaths.add(path);
}
});
return FFmpegConcatUtil.mergeVideosSideBySide(videoFilePaths, folder, logger).getAbsolutePath();
} else {
return testRunDevice.getScreenRecorder().finishRecording();
videoFilePaths.add(testRunDevice.getScreenRecorder().finishRecording());
}
return FFmpegConcatUtil.mergeVideosSideBySide(videoFilePaths, folder, logger).getAbsolutePath();
}

public void startNetworkMonitor(@NotNull TestRunDevice testRunDevice, String rule, File resultFolder, @Nullable Logger logger) {
Expand Down
Loading