Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCA (Independent Publisher) Connector - Added and Updated Actions #3500

Merged
merged 39 commits into from
Jul 5, 2024

Conversation

gulshankhurana
Copy link
Contributor

@gulshankhurana gulshankhurana commented May 20, 2024

  • Fixed the 'Common Search' action.
  • Added 'Find Firm Details' and 'Find Product Details' actions.

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.
Con-Def Con-Test-CommonSearch-Individual Con-Test-CommonSearch-Fund Con-Test-CommonSearch-Firm Con-Test-FirmDetails Con-Test-ProductDetails Flow-CommonSearch-Individual Flow-CommonSearch-Firm Flow-CommonSearch-Fund Flow-FindFirmDetailsByFRN Flow-FindProductDetailsByPRN

Created Financial Conduct Authority (FCA) UK Connector folder and ReadME file underneath
Corrected the foldername
Uploaded the following files:
apiDefinition.swagger.json
apiProperties.json
Added the following files:
* apiDefinition.swagger.json
* apiProperties.json
…FCA) UK Connector/apiDefinition.swagger.json
Updated the title and description
Truncated the title to keep it 30 characters long
Truncated the title length to 30 characters
* Fixed 'Common Search' action 
* Added 'Find Firm Details' action
* Added 'Find Product Details' action
Updated apiProperties.json file
@vmanoharas
Copy link
Contributor

Hello @gulshankhurana,

Please accept my apologies, I thought I have reviewed and approved this PR already. Unfortunately, old name is also not accepted. Last time we had same issue so we have taken files from here manually and certified. Please see the validation error below and correct the title.

image

@gulshankhurana
Copy link
Contributor Author

gulshankhurana commented May 24, 2024

Hello @gulshankhurana,

Please accept my apologies, I thought I have reviewed and approved this PR already. Unfortunately, old name is also not accepted. Last time we had same issue so we have taken files from here manually and certified. Please see the validation error below and correct the title.

image

If only I knew what it meant, it's all like a foreign language to me. I don't know where the error is, let alone knowing how to resolve this :(

What would the quickest/easiest way for a non-dev like me to get my request approved? Start afresh with new pull request and fresh submission?
@vmanoharas

@vmanoharas
Copy link
Contributor

Hello @gulshankhurana,
Please accept my apologies, I thought I have reviewed and approved this PR already. Unfortunately, old name is also not accepted. Last time we had same issue so we have taken files from here manually and certified. Please see the validation error below and correct the title.
image

If only I knew what it meant, it's all like a foreign language to me. I don't know where the error is, let alone knowing how to resolve this :(

What would the quickest/easiest way for a non-dev like me to get my request approved? Start afresh with new pull request and fresh submission? @vmanoharas

Hello @gulshankhurana,

If you understand the error mentioned in the image below, the title should not be like all uppercase or lower case, it should be as per the example below.

-- AsHashTable

image

@gulshankhurana
Copy link
Contributor Author

gulshankhurana commented May 24, 2024

@vmanoharas , thanks for the prompt response. I really appreciate that.
Originally, the title was "FCA" only which I changed to "Financial Conduct Authority UK" but it was agaisnt the system rules to change the name so I changed it back to "FCA" and now you're saying that the system doesn't accept all capital letters but it did originally. Since "FCA" is an abbreviation so I can't/mustn't change it to "Fca".

What do you propose I should do? If possible, I'd rather go for the name "Financial Conduct Authority UK" as this is what the connector is all about.

@vmanoharas
Copy link
Contributor

Hello @gulshankhurana,

Sorry for lot of confusions created, we will go ahead with FCA now, and let's decide next time. As our certification process is going to change soon. I will request our engineers to take the files from here and certify it.

vmanoharas
vmanoharas previously approved these changes May 24, 2024
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.

@vmanoharas
Copy link
Contributor

[[certify-connector]]

@gulshankhurana
Copy link
Contributor Author

@vmanoharas, Thanks again for all your help.
Please advise how can I track the usage stats for my connector?

@vmanoharas
Copy link
Contributor

@vmanoharas, Thanks again for all your help. Please advise how can I track the usage stats for my connector?

@gulshankhurana, unfortunately, you cannot track as an Independent Publisher.

@gulshankhurana
Copy link
Contributor Author

gulshankhurana commented Jun 7, 2024

Hi @vmanoharas

Any luck progressing it to the deployment stage?

@vmanoharas
Copy link
Contributor

Hello @gulshankhurana, Yes, your connector was included in last week's deployment cycle and is expected to be completed within the next 2-3 weeks.

@gulshankhurana
Copy link
Contributor Author

gulshankhurana commented Jun 14, 2024

Hi @vmanoharas

Any further updates on deployment completion date?

@vmanoharas
Copy link
Contributor

Hi @vmanoharas

Any further updates on deployment completion date?

Hi @gulshankhurana,

your connector is being deployed, it may approximately complete in another 5 to 6 working days.

@gulshankhurana
Copy link
Contributor Author

gulshankhurana commented Jun 22, 2024

@vmanoharas , I've just created a new PR #3547 and wondering if this would delay the deployment of my existing (already approved) #3500 PR which is already included in the deployment schedule as confirmed by you last week.

@vmanoharas
Copy link
Contributor

Hello @gulshankhurana,

Your new changes in this PR #3547 will be approved and included after your current version of the connector deployed to all regions.

@gulshankhurana
Copy link
Contributor Author

Hello @gulshankhurana,

Your new changes in this PR #3547 will be approved and included after your current version of the connector deployed to all regions.

Thank @vmanoharas. Eagerly waiting for FCA connector update to be deployed.

@gulshankhurana
Copy link
Contributor Author

gulshankhurana commented Jun 27, 2024

Hi @vmanoharas, it's been 5 weeks now since you approved the changes to the FCA Connector. Are there any updates regarding deployment yet? Thanks.

@vmanoharas
Copy link
Contributor

Hi @vmanoharas, it's been 5 weeks now since you approved the changes to the FCA Connector. Are there any updates regarding deployment yet? Thanks.

Hi @gulshankhurana, Apologies for the delay in deploying your connector, now your connector is deployed to last but one region, it will be completed by early next week.

Thank you for your patience and understanding.

@gulshankhurana
Copy link
Contributor Author

Hi @vmanoharas, it's been 5 weeks now since you approved the changes to the FCA Connector. Are there any updates regarding deployment yet? Thanks.

Hi @gulshankhurana, Apologies for the delay in deploying your connector, now your connector is deployed to last but one region, it will be completed by early next week.

Thank you for your patience and understanding.

Hi @vmanoharas

Another week gone, still waiting :(

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Partner,
I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.

@vmanoharas
Copy link
Contributor

Hello @gulshankhurana ,
I hope you are doing well.
Congratulations, the deployment of your connector and documentation page was already completed, We have a short survey on the connector certification process that we would like for you to complete. Your feedback is appreciated and will help us improve the program.
Thank you very much for working with us.

@vmanoharas vmanoharas merged commit 850cc87 into microsoft:dev Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants